RE: [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask for ia64

Zhang, Xiantao
2008-03-31T01:40:25Z

Avi Kivity wrote:
> Zhang, Xiantao wrote:
>>
>> diff --git a/include/linux/smp.h b/include/linux/smp.h
>> index 55232cc..b71820b 100644
>> --- a/include/linux/smp.h
>> +++ b/include/linux/smp.h
>> @@ -56,6 +56,9 @@ int smp_call_function(void(*func)(void *info),
>> void *info, int retry, int wait);
>>
>> int smp_call_function_single(int cpuid, void (*func) (void *info),
>> void *info, int retry, int wait);
>> +int smp_call_function_mask(cpumask_t mask,
>> + void (*func)(void *), void *info,
>> + int wait);
>>
>>
>
> For all other archs, smp_call_function_mask() is declared in
> <asm/smp.h> so please define it there. A separate patch can move the
> declarations to <linux/smp.h>, since it makes sense to have just one
> declaration (and the uniprocessor version is declared there anyway).

OK, moved it to asm-ia64/smp.h first, although only x86 arch defined the
interface in current code. :)
Xiantao