public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: linux-ia64@vger.kernel.org
Subject: ate_resource->lowest_free_index signed or unsigned?
Date: Mon, 20 Apr 2009 16:45:06 +0000	[thread overview]
Message-ID: <49ECA692.2040007@gmail.com> (raw)

In arch/ia64/include/asm/sn/pcibr_provider.h:94

struct ate_resource{
        u64 *ate;
        u64 num_ate;
        u64 lowest_free_index;
};

as you see lowest_free_index is unsigned,

but in alloc_ate_resource() and free_ate_resource() it is
treated as signed:

static inline void free_ate_resource(struct ate_resource *ate_resource,
                                     int start)
{
        mark_ate(ate_resource, start, ate_resource->ate[start], 0);
        if ((ate_resource->lowest_free_index > start) ||
            (ate_resource->lowest_free_index < 0))
                ate_resource->lowest_free_index = start;
}

/*
 * alloc_ate_resource:  Allocate the requested number of ATEs.
 */
static inline int alloc_ate_resource(struct ate_resource *ate_resource,
                                     int ate_needed)
{
        int start_index;

        /*
         * Check for ate exhaustion.
         */
        if (ate_resource->lowest_free_index < 0)
                return -1;

        /*
         * Find the required number of free consecutive ates.
         */
        start_index             find_free_ate(ate_resource, ate_resource->lowest_free_index,
                          ate_needed);
        if (start_index >= 0)
                mark_ate(ate_resource, start_index, ate_needed, ate_needed);

        ate_resource->lowest_free_index             find_free_ate(ate_resource, ate_resource->lowest_free_index, 1);

        return start_index;
}

should it be signed instead?

             reply	other threads:[~2009-04-20 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-20 16:45 Roel Kluin [this message]
2009-04-21  6:46 ` ate_resource->lowest_free_index signed or unsigned? Jes Sorensen
2009-04-21 11:21 ` Roel Kluin
2009-04-21 11:31 ` Jes Sorensen
2009-04-21 12:15 ` Roel Kluin
2009-04-23 11:35 ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ECA692.2040007@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox