Linux IA64 platform development
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] acpi-cpufreq: Read buffer overflow?
Date: Fri, 07 Aug 2009 20:12:37 +0000	[thread overview]
Message-ID: <4A7C8AB5.90503@gmail.com> (raw)

If `data->acpi_data.state_count' is 0, we read from data->acpi_data.states[-1].

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Unsure whether this can happen.

diff --git a/arch/ia64/kernel/cpufreq/acpi-cpufreq.c b/arch/ia64/kernel/cpufreq/acpi-cpufreq.c
index 7b43545..7cdd1f6 100644
--- a/arch/ia64/kernel/cpufreq/acpi-cpufreq.c
+++ b/arch/ia64/kernel/cpufreq/acpi-cpufreq.c
@@ -95,7 +95,7 @@ extract_clock (
 		if (value = data->acpi_data.states[i].status)
 			return data->acpi_data.states[i].core_frequency;
 	}
-	return data->acpi_data.states[i-1].core_frequency;
+	return i ? data->acpi_data.states[i-1].core_frequency : 0;
 }
 
 

             reply	other threads:[~2009-08-07 20:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07 20:12 Roel Kluin [this message]
2009-08-07 20:41 ` [PATCH] acpi-cpufreq: Read buffer overflow? Yu, Fenghua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A7C8AB5.90503@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox