From: Avi Kivity <avi@redhat.com>
To: linux-ia64@vger.kernel.org
Subject: Re: kvm-ia64 spinlocks
Date: Thu, 17 Dec 2009 08:21:33 +0000 [thread overview]
Message-ID: <4B29EA0D.7040709@redhat.com> (raw)
On 12/17/2009 02:07 AM, Luck, Tony wrote:
> [resend with fixed vger address :-) ]
>
> Len Brown pointed out that allmodconfig is broken for
> ia64 because of:
>
> arch/ia64/kvm/vmm.c: In function 'vmm_spin_unlock':
> arch/ia64/kvm/vmm.c:70: error: 'spinlock_t' has no member named 'raw_lock'
>
> This is fall-out from the ia64 switch to ticket locks.
>
> I'm not sure why KVM needs to implement its own locking
> mechanisms ... if it does need to roll its own, it should
> not depend on the base kernel spinlock_t type.
It does, parts of the ia64 vmm run in guest context.
> One possible
> solution is to just have KVM define its own vmm_spinlock_t
> type (see patch below).
>
>
Looks good. Changelog/signoff?
> Or perhaps this code needs to implement ticket locks?
>
This will do for now, I believe.
--
error compiling committee.c: too many arguments to function
reply other threads:[~2009-12-17 8:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29EA0D.7040709@redhat.com \
--to=avi@redhat.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox