From: "H. Peter Anvin" <hpa@linux.intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: drivers/acpi/bgrt.c:undefined reference to `bgrt_tab' (defined in arch/x86/platform/efi/efi-bgrt
Date: Fri, 29 Mar 2013 21:50:51 +0000 [thread overview]
Message-ID: <51560CBB.2010408@linux.intel.com> (raw)
In-Reply-To: <20130327005555.GA14974@localhost>
On 03/29/2013 02:50 PM, Tony Luck wrote:
>
>
>
> On Tue, Mar 26, 2013 at 5:55 PM, Fengguang Wu <fengguang.wu@intel.com
> <mailto:fengguang.wu@intel.com>> wrote:
>
>
> The problem is, drivers/acpi/bgrt.c references bgrt_tab etc. variables
> defined in arch/x86/platform/efi/efi-bgrt.c which is obviously not
> available in ia64.
>
>
> So perhaps the solution is to not let the user configure
> this on IA64. I don't think we have platforms with
> boot graphics support (many ia64 machines are headless
> so have *no* graphics at all!).
>
> gmail will whitespace destroy this patch - but easier to type
> in the half dozen extra characters anyway:
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 4fc0ffc..8fcae6d 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -395,7 +395,7 @@ config ACPI_CUSTOM_METHOD
>
> config ACPI_BGRT
> bool "Boottime Graphics Resource Table support"
> - depends on EFI
> + depends on EFI && X86
> help
> This driver adds support for exposing the ACPI Boottime Graphics
> Resource Table, which allows the operating system to obtain
>
Makes sense to me.
Acked-by: H. Peter Anvin <hpa@zytor.com>
-hpa
prev parent reply other threads:[~2013-03-29 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 0:55 drivers/acpi/bgrt.c:undefined reference to `bgrt_tab' (defined in arch/x86/platform/efi/efi-bgrt.c) Fengguang Wu
2013-03-29 21:50 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51560CBB.2010408@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox