From: Yijing Wang <wangyijing@huawei.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH -v3 8/8] PCI: Replace printks with appropriate pr_*()
Date: Wed, 05 Jun 2013 02:32:24 +0000 [thread overview]
Message-ID: <51AEA338.3090901@huawei.com> (raw)
In-Reply-To: <1370343554-11812-9-git-send-email-wangyijing@huawei.com>
>> - printk(KERN_ERR "PCI: No memory for %s I/O port space\n",
>> + pr_err("PCI: No memory for %s I/O port space\n",
>
> Use dev_err() here, since you have the struct acpi_device pointer
> (info->bridge).
Sure, I will update it.
>
>> info->name);
>> goto out;
>> }
>> @@ -444,7 +444,7 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
>>
>> info = kzalloc(sizeof(*info), GFP_KERNEL);
>> if (!info) {
>> - printk(KERN_WARNING "pci_bus %04x:%02x: "
>> + pr_warn("pci_bus %04x:%02x: "
>> "ignored (out of memory)\n", domain, busnum);
>
> And here.
will update too, thanks!
>
>> kfree(controller);
>> return NULL;
>> @@ -779,7 +779,7 @@ static void __init set_pci_dfl_cacheline_size(void)
>>
>> status = ia64_pal_cache_summary(&levels, &unique_caches);
>> if (status != 0) {
>> - printk(KERN_ERR "%s: ia64_pal_cache_summary() failed "
>> + pr_err("%s: ia64_pal_cache_summary() failed "
>> "(status=%ld)\n", __func__, status);
>> return;
>> }
>> @@ -787,7 +787,7 @@ static void __init set_pci_dfl_cacheline_size(void)
>> status = ia64_pal_cache_config_info(levels - 1,
>> /* cache_type (data_or_unified)= */ 2, &cci);
>> if (status != 0) {
>> - printk(KERN_ERR "%s: ia64_pal_cache_config_info() failed "
>> + pr_err("%s: ia64_pal_cache_config_info() failed "
>> "(status=%ld)\n", __func__, status);
>> return;
>> }
>> --
>> 1.7.1
>>
>>
>
> .
>
--
Thanks!
Yijing
prev parent reply other threads:[~2013-06-05 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 10:59 [PATCH -v3 8/8] PCI: Replace printks with appropriate pr_*() Yijing Wang
2013-06-04 23:14 ` Bjorn Helgaas
2013-06-05 2:32 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AEA338.3090901@huawei.com \
--to=wangyijing@huawei.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox