From: David Daney <david.s.daney@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Daney <ddaney.cavm@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
linux-am33-list@redhat.com, David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 2/2] mn10300: Fix include dependency in irqflags.h
Date: Mon, 17 Jun 2013 14:48:55 +0000 [thread overview]
Message-ID: <51BF21D7.60707@gmail.com> (raw)
In-Reply-To: <CAMuHMdW4tZCzZ-4wTxsjfhu+UMZqsb2tuTo8+Yho-ZDE2dck8A@mail.gmail.com>
On 06/17/2013 03:12 AM, Geert Uytterhoeven wrote:
> On Mon, Jun 17, 2013 at 9:07 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Sun, Jun 16, 2013 at 10:06 PM, <ddaney.cavm@gmail.com> wrote:
>>> From: David Daney <david.daney@cavium.com>
>>>
>>> We need to pick up the definition of raw_smp_processor_id() from
>>> asm/smp.h. For the !SMP case, we need to supply a definition of
>>> raw_smp_processor_id().
>> Thanks, this fixes the build!
>>
>>> Signed-off-by: David Daney <david.daney@cavium.com>
>> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Sorry, I acked to soon. While SMP=n is fine (asb2303_defconfig),
> there's a new regression with asb2364_defconfig, which has SMP=y:
>
> CC arch/mn10300/kernel/asm-offsets.s
> In file included from
> /scratch/geert/linux/linux/arch/mn10300/include/asm/irqflags.h:18:0,
> from /scratch/geert/linux/linux/include/linux/irqflags.h:15,
> from /scratch/geert/linux/linux/include/linux/spinlock.h:53,
> from /scratch/geert/linux/linux/include/linux/seqlock.h:29,
> from /scratch/geert/linux/linux/include/linux/time.h:5,
> from /scratch/geert/linux/linux/include/uapi/linux/timex.h:56,
> from /scratch/geert/linux/linux/include/linux/timex.h:56,
> from /scratch/geert/linux/linux/include/linux/sched.h:17,
> from
> /scratch/geert/linux/linux/arch/mn10300/kernel/asm-offsets.c:7:
> /scratch/geert/linux/linux/arch/mn10300/include/asm/smp.h:88:34:
> error: unknown type name 'smp_call_func_t'
> make[4]: *** [arch/mn10300/kernel/asm-offsets.s] Error 1
I am truly in Include Hell. I will attempt a better fix...
David Daney
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2013-06-17 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 20:06 [PATCH 0/2] Fix v3.10-rc6 failures in ia64 and mn10300 ddaney.cavm
2013-06-16 20:06 ` [PATCH 1/2] ia64: Fix include dependency in asm/irqflags.h ddaney.cavm
2013-06-17 7:28 ` Geert Uytterhoeven
2013-06-16 20:06 ` [PATCH 2/2] mn10300: Fix include dependency in irqflags.h ddaney.cavm
2013-06-17 7:07 ` Geert Uytterhoeven
2013-06-17 10:12 ` Geert Uytterhoeven
2013-06-17 14:48 ` David Daney [this message]
2013-06-17 15:46 ` [PATCH v2] mn10300: Fix include dependency in irqflags.h et al ddaney.cavm
2013-06-17 19:01 ` Geert Uytterhoeven
2013-06-19 10:05 ` David Howells
2013-06-17 9:07 ` [PATCH 2/2] mn10300: Fix include dependency in irqflags.h David Howells
2013-06-17 10:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BF21D7.60707@gmail.com \
--to=david.s.daney@gmail.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=dhowells@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).