From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Date: Wed, 26 Mar 2014 15:25:16 +0000 Subject: Re: [PATCH v3 4/5] xen: Define EFI related stuff Message-Id: <5332FF6C02000078000027A5@nat28.tlf.novell.com> List-Id: References: <1395781076-12000-1-git-send-email-daniel.kiper@oracle.com> <1395781076-12000-5-git-send-email-daniel.kiper@oracle.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: stefano.stabellini@eu.citrix.com Cc: david.vrabel@citrix.com, ian.campbell@citrix.com, jeremy@goop.org, fenghua.yu@intel.com, matt.fleming@intel.com, tony.luck@intel.com, x86@kernel.org, tglx@linutronix.de, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, Daniel Kiper , konrad.wilk@oracle.com, Tang Liang , eshelton@pobox.com, mingo@redhat.com, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com >>> On 26.03.14 at 15:58, wrote: >> +struct xenpf_efi_runtime_call { >> + uint32_t function; >> + /* >> + * This field is generally used for per sub-function flags (defined >> + * below), except for the XEN_EFI_get_next_high_monotonic_count case, >> + * where it holds the single returned value. >> + */ >> + uint32_t misc; >> + unsigned long status; > > I realize that this is just the same as xen/include/public/platform.h, > but this field should be xen_ulong_t. Care to supply a patch to the canonical header? Jan