From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Tony Luck <tony.luck@gmail.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-ia64@vger.kernel.org, sparse@chrisli.org,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
linux-tip-commits@vger.kernel.org, akataria@vmware.com,
anil.s.keshavamurthy@intel.com,
"Suzuki K. Poulose" <suzuki@in.ibm.com>,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Chris Wright <chrisw@sous-sol.org>,
yrl.pp-manager.tt@hitachi.com,
Thomas Gleixner <tglx@linutronix.de>,
Tony Luck <tony.luck@intel.com>, Kevin Hao <haokexin@gmail.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
linuxppc-dev@lists.ozlabs.org, rdunlap@infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dl9pf@gmx.de, Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Re: [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64
Date: Tue, 01 Jul 2014 02:21:02 +0000 [thread overview]
Message-ID: <53B21B0E.8010707@hitachi.com> (raw)
In-Reply-To: <1404128176.7888.1.camel@concordia>
(2014/06/30 20:36), Michael Ellerman wrote:
> On Mon, 2014-06-30 at 12:14 +0900, Masami Hiramatsu wrote:
>> Ping? :)
>
> Yeah sorry. I started looking at this and got dragged into another mess.
>
> You seem to have duplicated the functionality of arch_deref_entry_point(),
> which was also added for kprobes, and for the same reason - ie. because some
> arches have strange function pointers. Is there some reason you can't use it?
Ah, right! Hmm, it seems some more work to update it. but basically, we can do.
BTW, is there any other users who need to access the actual function entry (for
kallsyms case)?
If so, I guess it'd better to merge this version and replace kprobe's local
arch_deref_entry_point() with generic function_entry() macro.
Thank you,
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2014-07-01 2:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 2:23 [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Masami Hiramatsu
2014-06-30 3:14 ` Masami Hiramatsu
2014-06-30 11:36 ` Michael Ellerman
2014-07-01 2:21 ` Masami Hiramatsu [this message]
2014-07-02 4:41 ` Michael Ellerman
2014-07-02 6:39 ` Masami Hiramatsu
2014-07-02 6:56 ` Michael Ellerman
2014-07-02 7:16 ` Masami Hiramatsu
2014-07-02 7:00 ` [PATCH v5 2/2] " Masami Hiramatsu
2014-07-08 12:07 ` Masami Hiramatsu
2014-07-14 17:17 ` Tony Luck
2014-07-15 2:11 ` Michael Ellerman
2014-07-15 2:24 ` Masami Hiramatsu
2014-07-15 3:16 ` Michael Ellerman
2014-07-15 3:19 ` Michael Ellerman
2014-07-15 7:16 ` Benjamin Herrenschmidt
2014-07-15 10:09 ` Masami Hiramatsu
2014-07-16 13:28 ` Ingo Molnar
2014-07-17 7:10 ` Masami Hiramatsu
2014-07-17 9:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B21B0E.8010707@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=dl9pf@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=haokexin@gmail.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rdunlap@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=sparse@chrisli.org \
--cc=suzuki@in.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@gmail.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox