From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Mon, 27 Oct 2014 01:06:22 +0000 Subject: Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata Message-Id: <544D9A8E.6030607@huawei.com> List-Id: References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-17-git-send-email-wangyijing@huawei.com> <20141025130428.GD16738@linux-mips.org> In-Reply-To: <20141025130428.GD16738@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ralf Baechle Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thierry Reding , Thomas Petazzoni , Liviu Dudau On 2014/10/25 21:04, Ralf Baechle wrote: > On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote: > >> +static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus) >> +{ >> + struct pci_controller *control = (struct pci_controller *)bus->sysdata; > > bus->sysdata is void * so this cast is unnecessary. Yes, will update it, thanks! > > Ralf > > . > -- Thanks! Yijing