Re: [PATCH 05/11] x86, mpx: add MPX to disaabled features

Dave Hansen
2014-11-14T18:38:03Z

On 11/14/2014 09:56 AM, Sergei Shtylyov wrote:
>> #define DISABLED_MASK6 0
>> #define DISABLED_MASK7 0
>> #define DISABLED_MASK8 0
>> -#define DISABLED_MASK9 0
>> +#define DISABLED_MASK9 (DISABLE_MPX)
>
> These parens are not really needed. Sorry to be a PITA and not saying
> this before.

One goal of the disabled features patch was to maintain parity with
required-features.h. It declares things this way:

> #define REQUIRED_MASK3 (NEED_NOPL)
> #define REQUIRED_MASK4 (NEED_MOVBE)

So, no, those aren't strictly needed, but there is precedent for them
and they do no harm. I think I'll leave them as-is.