From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Date: Wed, 16 Sep 2015 09:53:11 +0000 Subject: Re: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation Message-Id: <55F93C07.1050403@samsung.com> List-Id: References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-3-git-send-email-a.hajda@samsung.com> In-Reply-To: <1438934377-4922-3-git-send-email-a.hajda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tony Luck , Fenghua Yu Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > arch/ia64/sn/pci/tioce_provider.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c > index 46d3df4..2f13276 100644 > --- a/arch/ia64/sn/pci/tioce_provider.c > +++ b/arch/ia64/sn/pci/tioce_provider.c > @@ -1000,11 +1000,11 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont > * Allocate kernel bus soft and copy from prom. > */ > > - tioce_common = kzalloc(sizeof(struct tioce_common), GFP_KERNEL); > + tioce_common = kmemdup(prom_bussoft, sizeof(struct tioce_common), > + GFP_KERNEL); > if (!tioce_common) > return NULL; > > - memcpy(tioce_common, prom_bussoft, sizeof(struct tioce_common)); > tioce_common->ce_pcibus.bs_base = (unsigned long) > ioremap(REGION_OFFSET(tioce_common->ce_pcibus.bs_base), > sizeof(struct tioce_common));