From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Date: Wed, 15 Jun 2016 19:21:13 +0000 Subject: Re: [RFC PATCH-tip v2 4/6] locking/rwsem: move down rwsem_down_read_failed function Message-Id: <5761AAA9.1080406@hpe.com> List-Id: References: <1465944489-43440-1-git-send-email-Waiman.Long@hpe.com> <1465944489-43440-5-git-send-email-Waiman.Long@hpe.com> <20160615174055.GS30921@twins.programming.kicks-ass.net> In-Reply-To: <20160615174055.GS30921@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, Davidlohr Bueso , Jason Low , Dave Chinner , Scott J Norton , Douglas Hatch On 06/15/2016 01:40 PM, Peter Zijlstra wrote: > On Tue, Jun 14, 2016 at 06:48:07PM -0400, Waiman Long wrote: >> Move the rwsem_down_read_failed() function down to below the optimistic >> spinning section before enabling optimistic spinning for the readers. > newline > >> There is no change in code. > Changelog fails to explain the why part. Thanks for pointing this out. I will update the changelog to mention that the movement is needed because it is going to call rwsem_optimistic_spin() in later patch. Cheers, Longman