From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [patch] 0/5 2.4.25-pre7 mca.c cleanup
Date: Mon, 02 Feb 2004 07:00:01 +0000 [thread overview]
Message-ID: <6503.1075705201@kao2.melbourne.sgi.com> (raw)
mca.c has potential deadlocks on printk() for MCA and INIT records,
they are not irq safe.
There is a lot of crud in mca.c, with obsolete printing code, unused
declarations, functions and data that are global when they should be
static, functions and data that are not used or are only set to 0,
function returns that are tested but are always 0. In addition the
code is disordered, requiring forward declarations and scattering
related functions to different parts of the file. All of which make it
awkward to follow the code.
The following 5 patches do :-
1 Avoid deadlock when using printk() for MCA and INIT records.
2 Delete all record printing code, moved to salinfo_decode in user space.
3 Mark variables and functions static where possible.
4 Delete dead variables and functions.
5 Reorder to remove the need for forward declarations and to consolidate
related code.
Altogether they shrink mca.c from 2420 to 1322 lines and make it much
more readable.
The only functional change is the removal of any attempt to print the
CMC/CPE/MCA/INIT record contents in the kernel. Now we just get one
line to say that a record has been detected, except for MCA which
prints nothing at all.
next reply other threads:[~2004-02-02 7:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 7:00 Keith Owens [this message]
2004-02-03 0:36 ` [patch] 0/5 2.4.25-pre7 mca.c cleanup Ben Woodard
2004-02-03 1:27 ` Keith Owens
2004-02-04 1:19 ` Ben Woodard
2004-02-04 2:45 ` Ben Woodard
2004-02-04 7:18 ` Hidetoshi Seto
2004-02-04 20:59 ` Keith Owens
2004-02-04 23:27 ` Bjorn Helgaas
2004-02-04 23:42 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6503.1075705201@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox