From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.6.5 Improve interrupt handling on contended spinlocks
Date: Fri, 09 Apr 2004 07:42:11 +0000 [thread overview]
Message-ID: <7374.1081496531@ocs3.ocs.com.au> (raw)
In-Reply-To: <4198.1081394377@kao2.melbourne.sgi.com>
On Thu, 8 Apr 2004 17:07:44 -0700,
David Mosberger <davidm@napali.hpl.hp.com> wrote:
>>>>>> On Thu, 08 Apr 2004 13:19:37 +1000, Keith Owens <kaos@sgi.com> said:
>
> Keith> spin_lock_irqsave() on a contended lock leaves interrupts disabled
> Keith> while waiting for the lock. If the interrupts were enabled before
> Keith> spin_lock_irqsave then this has the nasty side effect of preventing
> Keith> interrupt handling while waiting for the lock. Change the contention
> Keith> path to enable interrupts if it is safe to do so, allowing the cpu to
> Keith> process interrupts while waiting for the lock.
>
>Seems like a reasonable thing to me. I'm fine with the ia64-specific
>bits, so I guess the only question is whether the linux/spinlock.h
>bits will be accepted.
Catch 22. The ia64 code cannot be changed without the change to
linux/spinlock.h, that change cannot be justified without at least one
architecture using it. David, could you send the change to Linus as an
ia64 patch, other architectures can define _raw_spin_lock_flags if they
want it.
next prev parent reply other threads:[~2004-04-09 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-08 3:19 [patch] 2.6.5 Improve interrupt handling on contended spinlocks Keith Owens
2004-04-09 0:07 ` David Mosberger
2004-04-09 7:42 ` Keith Owens [this message]
2004-04-09 16:07 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7374.1081496531@ocs3.ocs.com.au \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox