From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Fenghua Yu <fenghua.yu@intel.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v3] ia64: fix module loading for gcc-5.4
Date: Sun, 09 Apr 2017 08:27:52 +0000 [thread overview]
Message-ID: <79cc2afd-1655-c276-a53f-2e2202a7e0ee@users.sourceforge.net> (raw)
In-Reply-To: <20170408195318.18080-1-slyfox@gentoo.org>
> Starting from gcc-5.4+ gcc generates MLX
How do you think about to omit the plus character?
> instructions in more cases to refer local
> symbols:
I wonder about your choice of a line length limit here.
> That caused ia64 module loader to choke
> on such instructions:
> fuse: invalid slot number 1 for IMM64
Why does it matter to check such a value?
> … That limitation was fixed in linux by
Would it be nicer to write “in corresponding source code by the”?
> Change since v2: checkpatched, fixed typos by found by Markus Elfring
Does this version information contain an unwanted word repetition?
How does it fit to the identifier “v3” in the commit subject?
Regards,
Markus
next prev parent reply other threads:[~2017-04-09 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <to=<20170408081449.4872-1-slyfox@gentoo.org>
2017-04-08 19:53 ` [PATCH v3] ia64: fix module loading for gcc-5.4 Sergei Trofimovich
2017-04-09 8:27 ` SF Markus Elfring [this message]
2017-04-09 8:51 ` Sergei Trofimovich
2017-04-09 9:02 ` SF Markus Elfring
2017-04-09 10:38 ` Sergei Trofimovich
2017-04-10 17:23 ` [PATCH v3] ia64: fix module loading for gcc-5.4+ SF Markus Elfring
2017-04-10 21:53 ` Sergei Trofimovich
2017-04-29 18:14 ` [PATCH v3] ia64: fix module loading for gcc-5.4 Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cc2afd-1655-c276-a53f-2e2202a7e0ee@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=hjl.tools@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slyfox@gentoo.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).