Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

Sergei Trofimovich
2021-03-27T10:24:33Z

On Wed, 17 Mar 2021 18:28:31 +0100
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote:

> Hi Sergei!
>
> On 3/12/21 11:27 PM, Sergei Trofimovich wrote:
> > The failure initially observed as boot failure on rx3600 ia64 machine
> > with RAID bus controller: Hewlett-Packard Company Smart Array P600:
> >
> > kernel unaligned access to 0xe000000105dd8b95, ip=0xa000000100b87551
> > kernel unaligned access to 0xe000000105dd8e95, ip=0xa000000100b87551
> > hpsa 0000:14:01.0: Controller reports max supported commands of 0 Using 16 instead. Ensure that firmware is up to date.
> > swapper/0[1]: error during unaligned kernel access
> >
> > Here unaligned access comes from 'struct CommandList' that happens
> > to be packed. The change f749d8b7a ("scsi: hpsa: Correct dev cmds
> > outstanding for retried cmds") introduced unexpected padding and
> > un-aligned atomic_t from natural alignment to something else.
> >
> > This change does not remove packing annotation from struct but only
> > restores alignment of atomic variable.
> >
> > The change is tested on the same rx3600 machine.
>
> I just gave it a try on my RX2660 and for me, the hpsa driver won't load even
> with your patch.
>
> Can you share your kernel configuration so I can give it a try?

Sure! Here is a config from a few days ago:
https://dev.gentoo.org/~slyfox/configs/guppy-config-5.12.0-rc4-00016-g427684abc9fd-dirty

--

Sergei