From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Mon, 21 Dec 2020 05:44:13 +0000 Subject: Re: [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ Message-Id: <87ft3zyaqa.fsf@mpe.ellerman.id.au> List-Id: References: <20201218143122.19459-1-info@metux.net> <20201218143122.19459-2-info@metux.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andy Shevchenko , "Enrico Weigelt, metux IT consult" Cc: Linux Kernel Mailing List , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Catalin Marinas , Will Deacon , msalter@redhat.com, jacquiot.aurelien@gmail.com, gerg@linux-m68k.org, Geert Uytterhoeven , Thomas Bogendoerfer , James Bottomley , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Linus Walleij , Bartosz Golaszewski , Marc Zyngier , Tony Lindgren , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , linux-s390@vger.kernel.org, Linux-SH , sparclinux@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Linux OMAP Mailing List , Linux-Arch Andy Shevchenko writes: > On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult > wrote: > >> + if (printk_ratelimit()) >> + pr_warn("spurious IRQ: irq=%d hwirq=%d nr_irqs=%d\n", >> + irq, hwirq, nr_irqs); > > Perhaps you missed pr_warn_ratelimit() macro which is already in the > kernel for a long time. pr_warn_ratelimited() which calls printk_ratelimited(). And see the comment above printk_ratelimit(): /* * Please don't use printk_ratelimit(), because it shares ratelimiting state * with all other unrelated printk_ratelimit() callsites. Instead use * printk_ratelimited() or plain old __ratelimit(). */ cheers