From: "Eric W. Biederman" <ebiederm@xmission.com>
To: linux-kernel@vger.kernel.org
Cc: rjw@rjwysocki.net, oleg@redhat.com, mingo@kernel.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, mgorman@suse.de, bigeasy@linutronix.de,
Will Deacon <will@kernel.org>,
tj@kernel.org, linux-pm@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-um@lists.infradead.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-xtensa@linux-xtensa.org, Jann Horn <jannh@google.com>,
Kees Cook <keescook@chromium.org>,
linux-ia64@vger.kernel.org
Subject: [PATCH 0/12] ptrace: cleaning up ptrace_stop
Date: Fri, 29 Apr 2022 21:46:59 +0000 [thread overview]
Message-ID: <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Tue, 26 Apr 2022 17:50:21 -0500")
The states TASK_STOPPED and TASK_TRACE are special in they can not
handle spurious wake-ups. This plus actively depending upon and
changing the value of tsk->__state causes problems for PREEMPT_RT and
Peter's freezer rewrite.
There are a lot of details we have to get right to sort out the
technical challenges and this is my parred back version of the changes
that contains just those problems I see good solutions to that I believe
are ready.
In particular I don't have a solution that is ready for the challenges
presented by wait_task_inactive.
I hope we can review these changes and then have a firm foundation
for the rest of the challenges.
There are cleanups to the ptrace support for xtensa, um, and
ia64.
I have sucked in the first patch of Peter's freezer change as
with minor modifications I believe it is ready to go.
Eric W. Biederman (12):
signal: Rename send_signal send_signal_locked
signal: Replace __group_send_sig_info with send_signal_locked
ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP
ptrace/xtensa: Replace PT_SINGLESTEP with TIF_SINGLESTEP
signal: Use lockdep_assert_held instead of assert_spin_locked
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
ptrace: Don't change __state
ptrace: Remove arch_ptrace_attach
ptrace: Always take siglock in ptrace_resume
ptrace: Only return signr from ptrace_stop if it was provided
ptrace: Always call schedule in ptrace_stop
sched,signal,ptrace: Rework TASK_TRACED, TASK_STOPPED state
arch/ia64/include/asm/ptrace.h | 4 --
arch/ia64/kernel/ptrace.c | 57 ----------------
arch/um/include/asm/thread_info.h | 2 +
arch/um/kernel/exec.c | 2 +-
arch/um/kernel/process.c | 2 +-
arch/um/kernel/ptrace.c | 8 +--
arch/um/kernel/signal.c | 4 +-
arch/xtensa/kernel/ptrace.c | 4 +-
arch/xtensa/kernel/signal.c | 4 +-
drivers/tty/tty_jobctrl.c | 4 +-
include/linux/ptrace.h | 7 --
include/linux/sched.h | 10 ++-
include/linux/sched/jobctl.h | 10 +++
include/linux/sched/signal.h | 23 ++++++-
include/linux/signal.h | 3 +-
kernel/ptrace.c | 88 +++++++++----------------
kernel/signal.c | 135 +++++++++++++++++---------------------
kernel/time/posix-cpu-timers.c | 6 +-
18 files changed, 145 insertions(+), 228 deletions(-)
Eric
next parent reply other threads:[~2022-04-29 21:46 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220421150248.667412396@infradead.org>
[not found] ` <20220421150654.817117821@infradead.org>
[not found] ` <87czhap9dy.fsf@email.froward.int.ebiederm.org>
[not found] ` <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org>
2022-04-29 21:46 ` Eric W. Biederman [this message]
2022-04-29 21:48 ` [PATCH v2 01/12] signal: Rename send_signal send_signal_locked Eric W. Biederman
2022-05-02 7:50 ` Sebastian Andrzej Siewior
2022-04-29 21:48 ` [PATCH v2 02/12] signal: Replace __group_send_sig_info with send_signal_locked Eric W. Biederman
2022-05-02 7:58 ` Sebastian Andrzej Siewior
2022-04-29 21:48 ` [PATCH v2 03/12] ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 04/12] ptrace/xtensa: Replace PT_SINGLESTEP " Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 05/12] signal: Use lockdep_assert_held instead of assert_spin_locked Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 06/12] ptrace: Reimplement PTRACE_KILL by always sending SIGKILL Eric W. Biederman
2022-05-02 14:37 ` Oleg Nesterov
2022-05-03 19:36 ` Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 07/12] ptrace: Don't change __state Eric W. Biederman
2022-04-29 22:27 ` Peter Zijlstra
2022-05-02 8:59 ` Sebastian Andrzej Siewior
2022-05-02 15:39 ` Oleg Nesterov
2022-05-02 16:35 ` Eric W. Biederman
2022-05-03 13:41 ` Oleg Nesterov
2022-05-03 20:45 ` Eric W. Biederman
2022-05-04 14:02 ` Oleg Nesterov
2022-05-04 17:37 ` Eric W. Biederman
2022-05-04 18:28 ` Eric W. Biederman
2022-05-02 15:47 ` Oleg Nesterov
2022-04-29 21:48 ` [PATCH v2 08/12] ptrace: Remove arch_ptrace_attach Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 09/12] ptrace: Always take siglock in ptrace_resume Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 10/12] ptrace: Only return signr from ptrace_stop if it was provided Eric W. Biederman
2022-05-02 10:08 ` Sebastian Andrzej Siewior
2022-04-29 21:48 ` [PATCH v2 11/12] ptrace: Always call schedule in ptrace_stop Eric W. Biederman
2022-04-29 21:48 ` [PATCH v2 12/12] sched,signal,ptrace: Rework TASK_TRACED, TASK_STOPPED state Eric W. Biederman
2022-05-02 10:18 ` Sebastian Andrzej Siewior
2022-05-02 13:38 ` [PATCH 0/12] ptrace: cleaning up ptrace_stop Sebastian Andrzej Siewior
2022-05-04 22:39 ` [PATCH v3 0/11] " Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 01/11] signal: Rename send_signal send_signal_locked Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 02/11] signal: Replace __group_send_sig_info with send_signal_locked Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 03/11] ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 04/11] ptrace/xtensa: Replace PT_SINGLESTEP " Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 05/11] ptrace: Remove arch_ptrace_attach Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 06/11] signal: Use lockdep_assert_held instead of assert_spin_locked Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 07/11] ptrace: Reimplement PTRACE_KILL by always sending SIGKILL Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 08/11] ptrace: Admit ptrace_stop can generate spuriuos SIGTRAPs Eric W. Biederman
2022-05-05 14:57 ` Oleg Nesterov
2022-05-05 16:59 ` Eric W. Biederman
2022-05-05 15:01 ` Oleg Nesterov
2022-05-05 17:21 ` Eric W. Biederman
2022-05-05 17:27 ` Oleg Nesterov
2022-05-05 15:28 ` Oleg Nesterov
2022-05-05 17:53 ` Eric W. Biederman
2022-05-05 18:10 ` Oleg Nesterov
2022-05-04 22:40 ` [PATCH v3 09/11] ptrace: Don't change __state Eric W. Biederman
2022-05-05 12:50 ` Sebastian Andrzej Siewior
2022-05-05 16:48 ` Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 10/11] ptrace: Always take siglock in ptrace_resume Eric W. Biederman
2022-05-04 22:40 ` [PATCH v3 11/11] sched,signal,ptrace: Rework TASK_TRACED, TASK_STOPPED state Eric W. Biederman
2022-05-05 18:25 ` [PATCH v4 0/12] ptrace: cleaning up ptrace_stop Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 01/12] signal: Rename send_signal send_signal_locked Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 02/12] signal: Replace __group_send_sig_info with send_signal_locked Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 03/12] ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 04/12] ptrace/xtensa: Replace PT_SINGLESTEP " Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 05/12] ptrace: Remove arch_ptrace_attach Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 06/12] signal: Use lockdep_assert_held instead of assert_spin_locked Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 07/12] ptrace: Reimplement PTRACE_KILL by always sending SIGKILL Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 08/12] ptrace: Document that wait_task_inactive can't fail Eric W. Biederman
2022-05-06 6:55 ` Sebastian Andrzej Siewior
2022-05-05 18:26 ` [PATCH v4 09/12] ptrace: Admit ptrace_stop can generate spuriuos SIGTRAPs Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 10/12] ptrace: Don't change __state Eric W. Biederman
2022-05-06 15:09 ` Oleg Nesterov
2022-05-06 19:42 ` Eric W. Biederman
2022-05-10 14:23 ` Oleg Nesterov
2022-05-10 15:17 ` Eric W. Biederman
2022-05-10 15:34 ` Oleg Nesterov
2022-05-05 18:26 ` [PATCH v4 11/12] ptrace: Always take siglock in ptrace_resume Eric W. Biederman
2022-05-05 18:26 ` [PATCH v4 12/12] sched,signal,ptrace: Rework TASK_TRACED, TASK_STOPPED state Eric W. Biederman
2022-06-21 13:00 ` Alexander Gordeev
2022-06-21 14:02 ` Eric W. Biederman
2022-06-21 15:15 ` Alexander Gordeev
2022-06-21 17:47 ` Eric W. Biederman
2022-06-25 16:34 ` Eric W. Biederman
2022-06-28 18:36 ` Alexander Gordeev
2022-06-28 22:42 ` Eric W. Biederman
2022-06-28 22:48 ` Steven Rostedt
2022-06-29 3:39 ` Eric W. Biederman
2022-06-29 20:25 ` Alexander Gordeev
2022-07-05 15:44 ` Peter Zijlstra
2022-07-06 6:56 ` Alexander Gordeev
2022-06-28 23:15 ` Steven Rostedt
2022-07-05 13:47 ` Sven Schnelle
2022-07-05 17:28 ` Sven Schnelle
2022-07-05 19:25 ` Peter Zijlstra
2022-07-06 7:58 ` Sven Schnelle
2022-07-06 8:59 ` Peter Zijlstra
2022-07-06 9:27 ` Sven Schnelle
2022-07-06 10:11 ` Peter Zijlstra
2022-05-06 14:14 ` [PATCH v4 0/12] ptrace: cleaning up ptrace_stop Oleg Nesterov
2022-05-06 14:38 ` Eric W. Biederman
2022-05-06 21:26 ` Kees Cook
2022-05-06 21:59 ` Eric W. Biederman
2022-05-10 14:11 ` Oleg Nesterov
2022-05-10 14:26 ` Eric W. Biederman
2022-05-10 14:45 ` Sebastian Andrzej Siewior
2022-05-10 15:18 ` Eric W. Biederman
2022-05-11 20:00 ` Eric W. Biederman
2022-05-18 22:49 ` [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Eric W. Biederman
2022-05-18 22:53 ` [PATCH 01/16] signal/alpha: Remove unused definition of TASK_REAL_PARENT Eric W. Biederman
2022-05-18 22:53 ` [PATCH 02/16] signal/ia64: Remove unused definition of IA64_TASK_REAL_PARENT_OFFSET Eric W. Biederman
2022-05-18 22:53 ` [PATCH 03/16] kdb: Use real_parent when displaying a list of processes Eric W. Biederman
2022-05-19 7:56 ` Peter Zijlstra
2022-05-19 18:06 ` Eric W. Biederman
2022-05-19 20:52 ` Doug Anderson
2022-05-19 23:48 ` Eric W. Biederman
2022-05-20 23:01 ` Doug Anderson
2022-05-18 22:53 ` [PATCH 04/16] powerpc/xmon: " Eric W. Biederman
2022-05-18 22:53 ` [PATCH 05/16] ptrace: Remove dead code from __ptrace_detach Eric W. Biederman
2022-05-24 11:42 ` Oleg Nesterov
2022-05-25 14:33 ` Oleg Nesterov
2022-06-06 16:06 ` Eric W. Biederman
2022-05-18 22:53 ` [PATCH 06/16] ptrace: Remove unnecessary locking in ptrace_(get|set)siginfo Eric W. Biederman
2022-05-24 13:25 ` Oleg Nesterov
2022-05-18 22:53 ` [PATCH 07/16] signal: Wake up the designated parent Eric W. Biederman
2022-05-24 13:25 ` Oleg Nesterov
2022-05-24 16:28 ` Oleg Nesterov
2022-05-25 14:28 ` Oleg Nesterov
2022-06-06 22:10 ` Eric W. Biederman
2022-06-07 15:26 ` Oleg Nesterov
2022-05-18 22:53 ` [PATCH 08/16] ptrace: Only populate last_siginfo from ptrace Eric W. Biederman
2022-05-24 15:27 ` Oleg Nesterov
2022-06-06 22:16 ` Eric W. Biederman
2022-06-07 15:29 ` Oleg Nesterov
2022-05-18 22:53 ` [PATCH 09/16] ptrace: In ptrace_setsiginfo deal with invalid si_signo Eric W. Biederman
2022-05-18 22:53 ` [PATCH 10/16] ptrace: In ptrace_signal look at what the debugger did with siginfo Eric W. Biederman
2022-05-18 22:53 ` [PATCH 11/16] ptrace: Use si_sino as the signal number to resume with Eric W. Biederman
2022-05-18 22:53 ` [PATCH 12/16] ptrace: Stop protecting ptrace_set_signr with tasklist_lock Eric W. Biederman
2022-05-18 22:53 ` [PATCH 13/16] ptrace: Document why ptrace_setoptions does not need a lock Eric W. Biederman
2022-05-18 22:53 ` [PATCH 14/16] signal: Protect parent child relationships by childs siglock Eric W. Biederman
2022-05-18 22:53 ` [PATCH 15/16] ptrace: Use siglock instead of tasklist_lock in ptrace_check_attach Eric W. Biederman
2022-05-18 22:53 ` [PATCH 16/16] signal: Always call do_notify_parent_cldstop with siglock held Eric W. Biederman
2022-05-20 16:19 ` kernel test robot
[not found] ` <CALWUPBdFDLuT7JaNGSJ_UXbHf8y9uKdC-SkAqzd=FQC0MX4nNQ@mail.gmail.com>
2022-05-19 6:19 ` [PATCH 00/16] ptrace: cleanups and calling do_cldstop with only siglock Sebastian Andrzej Siewior
2022-05-19 18:05 ` Eric W. Biederman
2022-05-20 5:24 ` Kyle Huey
2022-06-06 16:12 ` Eric W. Biederman
2022-06-09 19:59 ` Kyle Huey
2022-05-20 7:33 ` Sebastian Andrzej Siewior
2022-05-20 19:32 ` Eric W. Biederman
2022-05-20 19:58 ` Peter Zijlstra
2022-05-20 9:19 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bigeasy@linutronix.de \
--cc=chris@zankel.net \
--cc=dietmar.eggemann@arm.com \
--cc=jannh@google.com \
--cc=jcmvbkbc@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox