Re: [PATCH 1/3] mm: replace memmap_context by memplug_context

Laurent Dufour
2020-09-11T16:23:00Z

Le 11/09/2020 à 16:59, David Hildenbrand a écrit :
>> struct page *start;
>> struct memmap_init_callback_data args;
>> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
>> index 375515803cd8..cd2bd21d3a4d 100644
>> --- a/include/linux/memory_hotplug.h
>> +++ b/include/linux/memory_hotplug.h
>> @@ -15,6 +15,15 @@ struct memory_block;
>> struct resource;
>> struct vmem_altmap;
>>
>> +/*
>> + * Memory plugin context, use to differentiate memory added at boot time and
>
> "Memory plugin context" sounds weird.

Any suggestion ?

>> + * hot-plugged memory.
>> + */
>> +enum memplug_context {
>> + MEMPLUG_EARLY,
>> + MEMPLUG_HOTPLUG,
>> +};
>
> Not fully sure this is the right place, though. memory_hotplug.h is
> about MEMPLUG_HOTPLUG only ... I'd leave it at the old spot.

Fair enough.