Re: [PATCH 1/3] mm: replace memmap_context by memplug_context

David Hildenbrand
2020-09-11T17:34:25Z

On 11.09.20 18:23, Laurent Dufour wrote:
> Le 11/09/2020 à 16:59, David Hildenbrand a écrit :
>>> struct page *start;
>>> struct memmap_init_callback_data args;
>>> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
>>> index 375515803cd8..cd2bd21d3a4d 100644
>>> --- a/include/linux/memory_hotplug.h
>>> +++ b/include/linux/memory_hotplug.h
>>> @@ -15,6 +15,15 @@ struct memory_block;
>>> struct resource;
>>> struct vmem_altmap;
>>>
>>> +/*
>>> + * Memory plugin context, use to differentiate memory added at boot time and
>>
>> "Memory plugin context" sounds weird.
>
> Any suggestion ?
>

I'm not a native speaker, but "plugin" sounds weird in this context.
Maybe simply drop it and start right away with "Differentiate memory
added ..."

--
Thanks,

David / dhildenb