Re: [PATCH 1/3] mm: replace memmap_context by memplug_context

David Hildenbrand
2020-09-11T14:59:51Z

> struct page *start;
> struct memmap_init_callback_data args;
> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
> index 375515803cd8..cd2bd21d3a4d 100644
> --- a/include/linux/memory_hotplug.h
> +++ b/include/linux/memory_hotplug.h
> @@ -15,6 +15,15 @@ struct memory_block;
> struct resource;
> struct vmem_altmap;
>
> +/*
> + * Memory plugin context, use to differentiate memory added at boot time and

"Memory plugin context" sounds weird.

> + * hot-plugged memory.
> + */
> +enum memplug_context {
> + MEMPLUG_EARLY,
> + MEMPLUG_HOTPLUG,
> +};

Not fully sure this is the right place, though. memory_hotplug.h is
about MEMPLUG_HOTPLUG only ... I'd leave it at the old spot.

--
Thanks,

David / dhildenb