From: Chen Gang <xili_gchen_5257@hotmail.com>
To: kernel mailing list <linux-kernel@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>
Subject: [PATCH] arch: ia64: kernel: perfmon: Check return value of insert_vm_struct()
Date: Sun, 23 Aug 2015 17:18:58 +0000 [thread overview]
Message-ID: <COL130-W46DBE61538E64374C967CB9630@phx.gbl> (raw)
In pfm_smpl_buffer_alloc, insert_vm_struct may also return -ENOMEM, so
need check it too.
And insert_vm_struct needn't consider about pfm_remap_buffer in failure
process ("goto error" is enough):
- pfm_remap_buffer doen't consider about remap_pfn_range.
- It is about the relationship between vma and smpl_buf.
- SO if both vma and smpl_buf are released ("goto error"), all things
are OK.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/ia64/kernel/perfmon.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c
index 60e02f7..ae77946 100644
--- a/arch/ia64/kernel/perfmon.c
+++ b/arch/ia64/kernel/perfmon.c
@@ -2330,7 +2330,11 @@ pfm_smpl_buffer_alloc(struct task_struct *task, struct file *filp, pfm_context_t
* now insert the vma in the vm list for the process, must be
* done with mmap lock held
*/
- insert_vm_struct(mm, vma);
+ if (insert_vm_struct(mm, vma)) {
+ DPRINT(("Can't insert vm structure.\n"));
+ up_write(&task->mm->mmap_sem);
+ goto error;
+ }
vm_stat_account(vma->vm_mm, vma->vm_flags, vma->vm_file,
vma_pages(vma));
--
next reply other threads:[~2015-08-23 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 17:18 Chen Gang [this message]
2015-09-04 3:43 ` [PATCH] arch: ia64: kernel: perfmon: Check return value of insert_vm_struct() Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=COL130-W46DBE61538E64374C967CB9630@phx.gbl \
--to=xili_gchen_5257@hotmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox