Re: [PATCH 13/21] arm64: convert to arch_cpu_is_hotpluggable()

Will Deacon
2023-12-11T13:21:34Z

On Tue, Nov 21, 2023 at 01:44:56PM +0000, Russell King (Oracle) wrote:
> Convert arm64 to use the arch_cpu_is_hotpluggable() helper rather than
> arch_register_cpu().
>
> Reviewed-by: Shaoqin Huang <shahuang@redhat.com>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> arch/arm64/kernel/setup.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 165bd2c0dd5a..42c690bb2d60 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -402,13 +402,9 @@ static inline bool cpu_can_disable(unsigned int cpu)
> return false;
> }
>
> -int arch_register_cpu(int num)
> +bool arch_cpu_is_hotpluggable(int num)
> {
> - struct cpu *cpu = &per_cpu(cpu_devices, num);
> -
> - cpu->hotpluggable = cpu_can_disable(num);
> -
> - return register_cpu(cpu, num);
> + return cpu_can_disable(num);
> }
>
> static void dump_kernel_offset(void)

Acked-by: Will Deacon <will@kernel.org>

Will