Re: [PATCH 04/21] Loongarch: remove arch_*register_cpu() exports

Jonathan Cameron
2023-11-30T16:48:43Z

On Tue, 21 Nov 2023 13:44:10 +0000
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote:

> arch_register_cpu() and arch_unregister_cpu() are not used by anything
> that can be a module - they are used by drivers/base/cpu.c and
> drivers/acpi/acpi_processor.c, neither of which can be a module.
>
> Remove the exports.
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> arch/loongarch/kernel/topology.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/kernel/topology.c b/arch/loongarch/kernel/topology.c
> index 3fd166006698..ae860fe81536 100644
> --- a/arch/loongarch/kernel/topology.c
> +++ b/arch/loongarch/kernel/topology.c
> @@ -25,7 +25,6 @@ int arch_register_cpu(int cpu)
>
> return ret;
> }
> -EXPORT_SYMBOL(arch_register_cpu);
>
> void arch_unregister_cpu(int cpu)
> {
> @@ -34,7 +33,6 @@ void arch_unregister_cpu(int cpu)
> c->hotpluggable = 0;
> unregister_cpu(c);
> }
> -EXPORT_SYMBOL(arch_unregister_cpu);
> #endif
>
> static int __init topology_init(void)