From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: linux-ia64@vger.kernel.org
Subject: RE: [PATCH] bug w/ shared interrupts
Date: Tue, 27 Apr 2004 11:57:19 +0000 [thread overview]
Message-ID: <MDEEKOKJPMPMKGHIFAMAOEPIDNAA.kaneshige.kenji@jp.fujitsu.com> (raw)
In-Reply-To: <1082989740.15656.20.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
Hi,
I don't know whether you are referring to my patch. But if so,
please try a following patch. The patch for sharing vector I sent
before contains a bug and I think this might cause a similar problem.
Thanks,
Kenji Kaneshige
This is a patch to fix the following bug:
Register_intr() changes pin->low32 even when it overrides the
interrupt info. This destroys the value of pin->low32 which is already
set by set_rte() or other staffs.
This patch is against linux-2.6.6-rc2 with share_vector.patch applied.
---
linux-2.6.6-rc2-kanesige/arch/ia64/kernel/iosapic.c | 1 -
1 files changed, 1 deletion(-)
diff -puN arch/ia64/kernel/iosapic.c~share_vector_bugfix
arch/ia64/kernel/iosapic.c
--- linux-2.6.6-rc2/arch/ia64/kernel/iosapic.c~share_vector_bugfix
2004-04-27 18:12:56.000000000 +0900
+++ linux-2.6.6-rc2-kanesige/arch/ia64/kernel/iosapic.c 2004-04-27
18:12:56.000000000 +0900
@@ -605,7 +605,6 @@ register_intr (unsigned int gsi, int vec
pin->polarity = polarity;
pin->addr = iosapic_address;
pin->gsi_base = gsi_base;
- pin->low32 = IOSAPIC_MASK;
iosapic_intr_info[vector].dmode = delivery;
iosapic_intr_info[vector].trigger = trigger;
iosapic_intr_info[vector].type = type;
_
[-- Attachment #2: share_vector_bugfix.patch --]
[-- Type: application/octet-stream, Size: 1025 bytes --]
This is a patch to fix the following bug:
Register_intr() changes pin->low32 even when it overrides the
interrupt info. This destroys the value of pin->low32 which is already
set by set_rte() or other staffs.
This patch is against linux-2.6.6-rc2 with share_vector.patch applied.
---
linux-2.6.6-rc2-kanesige/arch/ia64/kernel/iosapic.c | 1 -
1 files changed, 1 deletion(-)
diff -puN arch/ia64/kernel/iosapic.c~share_vector_bugfix arch/ia64/kernel/iosapic.c
--- linux-2.6.6-rc2/arch/ia64/kernel/iosapic.c~share_vector_bugfix 2004-04-27 18:12:56.000000000 +0900
+++ linux-2.6.6-rc2-kanesige/arch/ia64/kernel/iosapic.c 2004-04-27 18:12:56.000000000 +0900
@@ -605,7 +605,6 @@ register_intr (unsigned int gsi, int vec
pin->polarity = polarity;
pin->addr = iosapic_address;
pin->gsi_base = gsi_base;
- pin->low32 = IOSAPIC_MASK;
iosapic_intr_info[vector].dmode = delivery;
iosapic_intr_info[vector].trigger = trigger;
iosapic_intr_info[vector].type = type;
_
next prev parent reply other threads:[~2004-04-27 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-26 14:29 [PATCH] bug w/ shared interrupts Alex Williamson
2004-04-26 21:12 ` David Mosberger
2004-04-27 11:57 ` Kenji Kaneshige [this message]
2004-04-27 13:19 ` Kenji Kaneshige
2004-04-27 14:38 ` Bjorn Helgaas
2004-04-27 14:46 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MDEEKOKJPMPMKGHIFAMAOEPIDNAA.kaneshige.kenji@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox