Re: [Patch 2/3] Export get_one_pte_map.

Greg KH
2005-10-17T15:20:34Z

On Mon, Oct 17, 2005 at 10:14:30AM -0500, Robin Holt wrote:
> On Mon, Oct 17, 2005 at 01:33:53PM +0100, Hugh Dickins wrote:
> > On Mon, 17 Oct 2005, Robin Holt wrote:
> > > On Mon, Oct 17, 2005 at 01:41:52PM +0200, Dave Hansen wrote:
> > > > On Mon, 2005-10-17 at 06:31 -0500, Robin Holt wrote:
> > > > > On Fri, Oct 14, 2005 at 02:30:38PM -0700, Greg KH wrote:
> > > > > > On Fri, Oct 14, 2005 at 02:22:25PM -0500, Robin Holt wrote:
> > > > > > > +EXPORT_SYMBOL(get_one_pte_map);
> > >
> > > I got a little push from our internal incident tracking system for
> > > this being a module. _GPL it will be.
> >
> > Sorry, Robin, I've not been following your patches. But if you look
> > at 2.6.14-rc4-mm1, you'll find that there isn't even a get_one_pte_map
> > there. Though there's no certainty yet that my pt locking changes, or
> > Nick's PageReserved changes, will actually go forward, there's a lot of
> > work queued up in -mm that is likely to affect your code. And I don't
> > think exporting internal functions from mremap.c, _GPL or otherwise,
> > is the way to go.
>
> I am currently getting pressure from my management to get something
> checked into the tree for 2.6.15.

Your management seems to not understand how kernel development works :)

> Would it be reasonable to ask that the current patch be included and
> then I work up another patch which introduces a ->nopfn type change
> for the -mm tree?

The stuff in -mm is what is going to be in .15, so you have to work off
of that patchset if you wish to have something for .15.

Good luck,

greg k-h