From: Christoph Lameter <clameter@sgi.com>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 1/2] mm: Avoid putting a bad page back on the LRU
Date: Mon, 28 Apr 2008 19:39:06 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0804281238080.30548@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080428192358.GB14629@sgi.com>
On Mon, 28 Apr 2008, Russ Anderson wrote:
> +#if (BITS_PER_LONG > 32)
> +#define PageMemError(page) test_bit(PG_memerror, &(page)->flags)
> +#define SetPageMemError(page) set_bit(PG_memerror, &(page)->flags)
> +#define ClearPageMemError(page) clear_bit(PG_memerror, &(page)->flags)
> +#define PAGE_FLAGS (1 << PG_lru | 1 << PG_private | 1 << PG_locked | \
> + 1 << PG_buddy | 1 << PG_writeback | \
> + 1 << PG_slab | 1 << PG_swapcache | 1 << PG_active | \
> + 1UL << PG_memerror)
> +#else
> +#define PageMemError(page) 0
> +#define PAGE_FLAGS (1 << PG_lru | 1 << PG_private | 1 << PG_locked | \
> + 1 << PG_buddy | 1 << PG_writeback | \
> + 1 << PG_slab | 1 << PG_swapcache | 1 << PG_active)
> +#endif
> +#define PAGE_FLAGS_RECLAIM (PAGE_FLAGS | 1 << PG_reclaim | 1 << PG_dirty)
> +#define PAGE_FLAGS_RESERVE (PAGE_FLAGS | 1 << PG_reserved)
> +#define PAGE_FLAGS_DIRTY (PAGE_FLAGS | 1 << PG_reserved | 1 << PG_dirty)
> +
All the PAGE_FLAGS_xx things could be in a separate cleanup patch. Also
note that the way page flags are defined may change soon.
next prev parent reply other threads:[~2008-04-28 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 19:23 [PATCH 1/2] mm: Avoid putting a bad page back on the LRU Russ Anderson
2008-04-28 19:39 ` Christoph Lameter [this message]
2008-04-29 21:33 ` Andrew Morton
2008-04-29 14:17 ` Arjan van de Ven
2008-04-29 21:47 ` Russ Anderson
2008-07-18 20:36 ` [PATCH 1/2] mm: Avoid putting a bad page back on the LRU v7 Russ Anderson
2008-07-22 2:42 ` Nick Piggin
2008-07-23 22:13 ` Russ Anderson
2008-07-24 0:44 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0804281238080.30548@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox