From: Julia Lawall <julia@diku.dk>
To: tony.luck@intel.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/6] arch/ia64/kernel: remove null pointer dereference
Date: Mon, 12 May 2008 13:37:09 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0805121536370.3694@ask.diku.dk> (raw)
From: Julia Lawall <julia@diku.dk>
If data is NULL, it is not possible to access data->ret.
The problem was detected using the following semantic match
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@
* if (E = NULL)
{
... when != if (E = NULL) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p a/arch/ia64/kernel/palinfo.c b/arch/ia64/kernel/palinfo.c
--- a/arch/ia64/kernel/palinfo.c 2008-05-09 16:46:57.000000000 +0200
+++ b/arch/ia64/kernel/palinfo.c 2008-05-12 08:43:35.000000000 +0200
@@ -902,7 +902,6 @@ palinfo_smp_call(void *info)
palinfo_smp_data_t *data = (palinfo_smp_data_t *)info;
if (data = NULL) {
printk(KERN_ERR "palinfo: data pointer is NULL\n");
- data->ret = 0; /* no output */
return;
}
/* does this actual call */
next reply other threads:[~2008-05-12 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:37 Julia Lawall [this message]
2008-05-12 14:37 ` [PATCH 1/6] arch/ia64/kernel: remove null pointer dereference Simon Holm Thøgersen
2008-05-12 14:37 ` Julia Lawall
2008-05-12 15:40 ` [PATCH] Remove NULL pointer check for argument never passed as Simon Holm Thøgersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805121536370.3694@ask.diku.dk \
--to=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox