Re: [PATCH v1 05/10] asm-generic: Define 'funct_descr_t' to commonly describe function descriptors

Kees Cook
2021-10-13T07:27:19Z

On Wed, Oct 13, 2021 at 09:23:56AM +0200, Christophe Leroy wrote:
>
>
> Le 13/10/2021 à 09:01, Kees Cook a écrit :
> > On Mon, Oct 11, 2021 at 05:25:32PM +0200, Christophe Leroy wrote:
> > > We have three architectures using function descriptors, each with its
> > > own name.
> > >
> > > Add a common typedef that can be used in generic code.
> > >
> > > Also add a stub typedef for architecture without function descriptors,
> >
> > nit: funct_descr_t reads weird to me. why not func_desc_t ? Either way:
>
> func_desc_t already exists in powerpc. I have a patch to remove it as it is
> redundant with struct ppc64_opd_entry, but I didnt' want to include it in
> this series.
>
> But after all I can add it in this series, I'll add it in v2.

Ah-ha! That works for me. :) Thanks!

-Kees

--
Kees Cook