From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Fri, 10 Jun 2022 13:56:28 +0000 Subject: Re: [PATCH v2 4/6] bitops: define const_*() versions of the non-atomics Message-Id: List-Id: References: <20220610113427.908751-1-alexandr.lobakin@intel.com> <20220610113427.908751-5-alexandr.lobakin@intel.com> In-Reply-To: <20220610113427.908751-5-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Lobakin Cc: Arnd Bergmann , Yury Norov , Mark Rutland , Matt Turner , Brian Cain , Geert Uytterhoeven , Yoshinori Sato , Rich Felker , "David S. Miller" , Kees Cook , "Peter Zijlstra (Intel)" , Marco Elver , Borislav Petkov , Tony Luck , Greg Kroah-Hartman , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Jun 10, 2022 at 01:34:25PM +0200, Alexander Lobakin wrote: > Define const_*() variants of the non-atomic bitops to be used when > the input arguments are compile-time constants, so that the compiler > will be always to resolve those to compile-time constants as well. > Those are mostly direct aliases for generic_*() with one exception > for const_test_bit(): the original one is declared atomic-safe and > thus doesn't discard the `volatile` qualifier, so in order to let > optimize the code, define it separately disregarding the qualifier. > Add them to the compile-time type checks as well just in case. ... > /* Check that the bitops prototypes are sane */ > #define __check_bitop_pr(name) \ > - static_assert(__same_type(arch_##name, generic_##name) && \ > + static_assert(__same_type(const_##name, generic_##name) && \ > + __same_type(arch_##name, generic_##name) && \ > __same_type(name, generic_##name)) Can't it be a one line change and actually keeping ordering at the same time? -- With Best Regards, Andy Shevchenko