From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Date: Mon, 05 Sep 2022 09:33:29 +0000 Subject: Re: [PATCH] hugetlb: simplify hugetlb handling in follow_page_mask Message-Id: List-Id: References: <20220829234053.159158-1-mike.kravetz@oracle.com> <608934d4-466d-975e-6458-34a91ccb4669@redhat.com> <739dc825-ece3-a59f-adc5-65861676e0ae@redhat.com> <323fdb0f-c5a5-e0e5-1ff4-ab971bc295cc@redhat.com> <5f6a7c6b-5073-f050-8dae-6ee279a8bb0b@redhat.com> In-Reply-To: <5f6a7c6b-5073-f050-8dae-6ee279a8bb0b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Hildenbrand , Mike Kravetz Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , Baolin Wang , "Aneesh Kumar K . V" , Naoya Horiguchi , Michael Ellerman , Muchun Song , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" DQoNCkxlIDA1LzA5LzIwMjIgw6AgMTA6MzcsIERhdmlkIEhpbGRlbmJyYW5kIGEgw6ljcml0wqA6 DQo+IE9uIDAzLjA5LjIyIDA5OjA3LCBDaHJpc3RvcGhlIExlcm95IHdyb3RlOg0KPj4gK1Jlc2Vu ZGluZyB3aXRoIHZhbGlkIHBvd2VycGMgbGlzdCBhZGRyZXNzDQo+Pg0KPj4gTGUgMDIvMDkvMjAy MiDDoCAyMDo1MiwgRGF2aWQgSGlsZGVuYnJhbmQgYSDDqWNyaXTCoDoNCj4+Pj4+PiBBZGRpbmcg Q2hyaXN0b3BoZSBvbiBDYzoNCj4+Pj4+Pg0KPj4+Pj4+IENocmlzdG9waGUgZG8geW91IGtub3cg aWYgaXNfaHVnZXBkIGlzIHRydWUgZm9yIGFsbCBodWdldGxiIA0KPj4+Pj4+IGVudHJpZXMsIG5v dA0KPj4+Pj4+IGp1c3QgaHVnZXBkPw0KPj4NCj4+IGlzX2h1Z2VwZCgpIGlzIHRydWUgaWYgYW5k IG9ubHkgaWYgdGhlIGRpcmVjdG9yeSBlbnRyeSBwb2ludHMgdG8gYSBodWdlDQo+PiBwYWdlIGRp cmVjdG9yeSBhbmQgbm90IHRvIHRoZSBub3JtYWwgbG93ZXIgbGV2ZWwgZGlyZWN0b3J5Lg0KPj4N Cj4+IEFzIGZhciBhcyBJIHVuZGVyc3RhbmQgaWYgdGhlIGRpcmVjdG9yeSBlbnRyeSBpcyBub3Qg cG9pbnRpbmcgdG8gYW55DQo+PiBsb3dlciBkaXJlY3RvcnkgYnV0IGlzIGEgaHVnZSBwYWdlIGVu dHJ5LCBwWGRfbGVhZigpIGlzIHRydWUuDQo+Pg0KPj4NCj4+Pj4+Pg0KPj4+Pj4+IE9uIHN5c3Rl bXMgd2l0aG91dCBodWdlcGQgZW50cmllcywgSSBndWVzcyBwdGR1bXAgc2tpcHMgYWxsIA0KPj4+ Pj4+IGh1Z2V0bGIgZW50cmllcy4NCj4+Pj4+PiBTaWdoIQ0KPj4NCj4+IEFzIGZhciBhcyBJIGNh biBzZWUsIHB0ZHVtcF9wWGRfZW50cnkoKSBoYW5kbGVzIHRoZSBwWGRfbGVhZigpIGNhc2UuDQo+ Pg0KPj4+Pj4NCj4+Pj4+IElJVUMsIHRoZSBpZGVhIG9mIHB0ZHVtcF93YWxrX3BnZCgpIGlzIHRv IGR1bXAgcGFnZSB0YWJsZXMgZXZlbiANCj4+Pj4+IG91dHNpZGUNCj4+Pj4+IFZNQXMgKGZvciBk ZWJ1Z2dpbmcgcHVycG9zZXM/KS4NCj4+Pj4+DQo+Pj4+PiBJIGNhbm5vdCBjb252aW5jZSBteXNl bGYgdGhhdCB0aGF0J3MgYSBnb29kIGlkZWEgd2hlbiBvbmx5IGhvbGRpbmcgdGhlDQo+Pj4+PiBt bWFwIGxvY2sgaW4gcmVhZCBtb2RlLCBiZWNhdXNlIHdlIGNhbiBqdXN0IHNlZSBwYWdlIHRhYmxl cyBnZXR0aW5nDQo+Pj4+PiBmcmVlZCBjb25jdXJyZW50bHkgZS5nLiwgZHVyaW5nIGNvbmN1cnJl bnQgbXVubWFwKCkgLi4uIHdoaWxlIGhvbGRpbmcNCj4+Pj4+IHRoZSBtbWFwIGxvY2sgaW4gcmVh ZCB3ZSBtYXkgb25seSB3YWxrIGluc2lkZSBWTUEgYm91bmRhcmllcy4NCj4+Pj4+DQo+Pj4+PiBU aGF0IHRoZW4gcmFpc2VzIHRoZSBxdWVzdGlvbnMgaWYgd2UncmUgb25seSBjYWxsaW5nIHRoaXMg b24gDQo+Pj4+PiBzcGVjaWFsIE1Ncw0KPj4+Pj4gKGUuZy4sIGluaXRfbW0pIHdoZXJlYnkgd2Ug Y2Fubm90IHJlYWxseSBzZWUgY29uY3VycmVudCBtdW5tYXAoKSBhbmQNCj4+Pj4+IHdoZXJlIHdl IHNob3VsZG4ndCBoYXZlIGh1Z2V0bGIgbWFwcGluZ3Mgb3IgaHVnZXBkIGVudHJpZXMuDQo+Pg0K Pj4gQXQgbGVhc3Qgb24gcG93ZXJwYywgUFREVU1QIGhhbmRsZXMgb25seSBpbml0X21tLg0KPj4N Cj4+IEh1Z2VwYWdlIGFyZSB1c2VkIGF0IGxlYXN0IG9uIHBvd2VycGMgOHh4IGZvciBsaW5lYXIg bWVtb3J5IG1hcHBpbmcsIHNlZQ0KPj4NCj4+IGNvbW1pdCAzNDUzNmQ3ODA2ODMgKCJwb3dlcnBj Lzh4eDogQWRkIGEgZnVuY3Rpb24gdG8gZWFybHkgbWFwIGtlcm5lbA0KPj4gdmlhIGh1Z2UgcGFn ZXMiKQ0KPj4gY29tbWl0IGNmMjA5OTUxZmE3ZiAoInBvd2VycGMvOHh4OiBNYXAgbGluZWFyIG1l bW9yeSB3aXRoIGh1Z2UgcGFnZXMiKQ0KPj4NCj4+IGh1Z2VwZHMgbWF5IGFsc28gYmUgdXNlZCBp biB0aGUgZnV0dXJlIHRvIHVzZSBodWdlIHBhZ2VzIGZvciB2bWFwIGFuZA0KPj4gdm1hbGxvYywg c2VlIGNvbW1pdCBhNmE4ZjdjNGFhN2UgKCJwb3dlcnBjLzh4eDogYWRkIHN1cHBvcnQgZm9yIGh1 Z2UNCj4+IHBhZ2VzIG9uIFZNQVAgYW5kIFZNQUxMT0MiKQ0KPj4NCj4+IEFzIGZhciBhcyBJIGtu b3csIHBwYzY0IGFsc28gdXNlIGh1Z2UgcGFnZXMgZm9yIFZNQVAgYW5kIFZNQUxMT0MsIHNlZQ0K Pj4NCj4+IGNvbW1pdCBkOTA5ZjkxMDljMzAgKCJwb3dlcnBjLzY0cy9yYWRpeDogRW5hYmxlIEhB VkVfQVJDSF9IVUdFX1ZNQVAiKQ0KPj4gY29tbWl0IDhhYmRkZDk2OGEzMCAoInBvd2VycGMvNjRz L3JhZGl4OiBFbmFibGUgaHVnZSB2bWFsbG9jIG1hcHBpbmdzIikNCj4gDQo+IFRoZXJlIGlzIGEg ZGlmZmVyZW5jZSBiZXR3ZWVuIGFuIG9yZGluYXJ5IGh1Z2UgbWFwcGluZyAoZS5nLiwgYXMgdXNl ZCANCj4gZm9yIFRIUCkgYW5kIGEgYSBodWdldGxiIG1hcHBpbmcuDQo+IA0KPiBPdXIgY3VycmVu dCB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgaHVnZXBkIG9ubHkgYXBwbGllcyB0byBodWdldGxiLiAN Cj4gV291bGRuJ3Qgdm1hcC92bWFsbG9jIHVzZXIgb3JkaW5hcnkgaHVnZSBwbWQgZW50cmllcyBp bnN0ZWFkIG9mIGh1Z2VwZD8NCj4gDQoNCidodWdlcGQnIHN0YW5kcyBmb3IgaHVnZSBwYWdlIGRp cmVjdG9yeS4gSXQgaXMgaW5kZXBlbmRhbnQgb2Ygd2hldGhlciBhIA0KaHVnZSBwYWdlIGlzIHVz ZWQgZm9yIGh1Z2V0bGIgb3IgZm9yIGFueXRoaW5nIGVsc2UsIGl0IHJlcHJlc2VudHMgdGhlIA0K d2F5IHBhZ2VzIGFyZSBkZXNjcmliZWQgaW4gdGhlIHBhZ2UgdGFibGVzLg0KDQpJIGRvbid0IGtu b3cgd2hhdCB5b3UgbWVhbiBieSBfb3JkaW5hcnlfIGh1Z2UgcG1kIGVudHJ5Lg0KDQpMZXQncyB0 YWtlIHRoZSBleGVtcGxlIG9mIHBvd2VycGMgOHh4IHdoaWNoIGlzIHRoZSBvbmUgSSBrbm93IGJl c3QuIFRoaXMgDQppcyBhIHBvd2VycGMzMiwgc28gaXQgaGFzIHR3byBsZXZlbHMgOiBQR0QgYW5k IFBURS4gUEdEIGhhcyAxMDI0IGVudHJpZXMgDQphbmQgZWFjaCBlbnRyeSBjb3ZlcnMgYSA0TWJ5 dGVzIGFyZWEuIE5vcm1hbCBQVEUgaGFzIDEwMjQgZW50cmllcyBhbmQgDQplYWNoIGVudHJ5IGlz IGEgNGsgcGFnZS4gV2hlbiB5b3UgdXNlIDhNYnl0ZXMgcGFnZXMsIHlvdSBkb24ndCB1c2UgUFRF cyANCmFzIGl0IHdvdWxkIGJlIGEgd2FzdGUgb2YgbWVtb3J5LiBZb3UgdXNlIGEgaHVnZSBwYWdl IGRpcmVjdG9yeSB0aGF0IGhhcyANCmEgc2luZ2xlIGVudHJ5LCBhbmQgeW91IGhhdmUgdHdvIFBH RCBlbnRyaWVzIHBvaW50aW5nIHRvIHRoZSBodWdlIHBhZ2UgDQpkaXJlY3RvcnkuDQoNClNvbWUg dGltZSBhZ28sIGh1cGdlcGQgd2FzIGFsc28gdXNlZCBmb3IgNTEya2J5dGVzIHBhZ2VzIGFuZCAx NmtieXRlcyANCnBhZ2VzOg0KLSB0aGVyZSB3YXMgaHVnZSBwYWdlIGRpcmVjdG9yaWVzIHdpdGgg OHggNTEya2J5dGVzIHBhZ2VzLA0KLSB0aGVyZSB3YXMgaHVnZSBwYWdlIGRpcmVjdG9yaWVzIHdp dGggMjU2eCAxNmtieXRlcyBwYWdlcywNCg0KQW5kIHRoZSBQR0QvUE1EIGVudHJ5IHBvaW50cyB0 byBhIGh1Z2UgcGFnZSBkaXJlY3RvcnkgKEhVR0VQRCkgaW5zdGVhZCANCm9mIHBvaW50aW5nIHRv IGEgcGFnZSB0YWJsZSBkaXJlY3RvcnkgKFBURSkuDQoNClNpbmNlIGNvbW1pdCBiMjUwYzhjMDhj NzkgKCJwb3dlcnBjLzh4eDogTWFuYWdlIDUxMmsgaHVnZSBwYWdlcyBhcyANCnN0YW5kYXJkIHBh Z2VzLiIpLCB0aGUgOHh4IGRvZXNuJ3QgdXNlIGFueW1vcmUgaHVnZXBkIGZvciA1MTJrIGh1Z2Ug DQpwYWdlLCBidXQgb3RoZXIgcGxhdGZvcm1zIGxpa2UgcG93ZXJwYyBib29rM2UgZXh0ZW5zaXZl bHkgdXNlIGh1Z2UgcGFnZSANCmRpcmVjdG9yaWVzLg0KDQpJIGhvcGUgdGhpcyBjbGFyaWZpZXMg dGhlIHN1YmplY3QsIG90aGVyd2lzZSBJJ20gaGFwcHkgdG8gcHJvdmlkZSANCmZ1cnRoZXIgZGV0 YWlscy4NCg0KQ2hyaXN0b3BoZQ=