From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Wed, 17 Jan 2018 11:14:50 +0000 Subject: Re: [PATCH 4/5] Expand the INIT_SIGNALS and INIT_SIGHAND macros and remove Message-Id: List-Id: References: <151274828194.9961.4230316917108602662.stgit@warthog.procyon.org.uk> <151274831156.9961.11214505146256879075.stgit@warthog.procyon.org.uk> <19929.1514903630@warthog.procyon.org.uk> In-Reply-To: <19929.1514903630@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Howells Cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org On Tue, 2 Jan 2018, David Howells wrote: > Thomas Gleixner wrote: > > > > #define INIT_CPU_TIMERS(s) \ > > ... > > That macro is only used in init_task.c Why not moving it there and get rid > > of the whole macro maze in the header file? > > The reason I didn't get rid of it is that it's got more than one expansion > point. Same for INIT_PREV_CPUTIME and INIT_PID_LINK. Ah, sorry I missed that. So yes, the current patch is fine. Acked-by: Thomas Gleixner