public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-s390@vger.kernel.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING
Date: Sat, 29 Mar 2008 00:53:16 +0000	[thread overview]
Message-ID: <alpine.LFD.1.00.0803281746480.14670@woody.linux-foundation.org> (raw)
In-Reply-To: <20080329001341.7F93826FA1D@magilla.localdomain>



On Fri, 28 Mar 2008, Roland McGrath wrote:
>
> Set TIF_SIGPENDING in set_restore_sigmask.  This lets arch code take
> TIF_RESTORE_SIGMASK out of the set of bits that will be noticed on
> return to user mode.  On some machines those bits are scarce, and we
> can free this unneeded one up for other uses.

Hmm. That probably means that TIF_RESTORE_SIGMASK shouldn't be a "TIF" 
flag at all, but a "TS" ("thread status") flag.

The TS flags are faster, because they are thread-synchronous and do not 
need atomic accesses (ie they are purely thread-local in setting, testing 
and clearing).

Of course, it may well not be worth it. Unlike the TIF flags, the TS flags 
have been architecture-specific and I don't think all architectures even 
do them (x86 uses them for FP state bits and stuff like that).

I guess TIF_RESTORE_SIGMASK is never *so* performance-critical that we'd 
care about the difference between a single cycle (approx) for a non-atomic 
"or" into memory and an atomic bitop (~50 cycles or so). 

			Linus

  reply	other threads:[~2008-03-29  0:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-29  0:12 [PATCH 1/4] set_restore_sigmask Roland McGrath
2008-03-29  0:13 ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Roland McGrath
2008-03-29  0:53   ` Linus Torvalds [this message]
2008-03-29  2:24     ` Roland McGrath
2008-03-29  2:52       ` Linus Torvalds
2008-03-29  3:12         ` Roland McGrath
2008-03-29  3:11       ` [PATCH 1/2] HAVE_SET_RESTORE_SIGMASK Roland McGrath
2008-04-09 11:45         ` David Woodhouse
2008-04-10 20:32           ` Russell King
2008-04-11 13:40             ` David Woodhouse
2008-03-29  3:14       ` Roland McGrath
2008-03-29  3:14         ` [PATCH 2/2] x86 TS_RESTORE_SIGMASK Roland McGrath
2008-03-31 13:01           ` Ingo Molnar
2008-03-31 19:30             ` Roland McGrath
2008-03-30 10:53     ` [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING Paul Mackerras
2008-04-08 11:35     ` Oleg Nesterov
2008-04-08 14:53       ` Linus Torvalds
2008-04-08 19:51       ` Roland McGrath
2008-04-09 11:16       ` David Woodhouse
2008-04-09 11:39         ` Oleg Nesterov
2008-04-09 12:57           ` Petr Tesarik
2008-04-09 16:14           ` David Woodhouse
2008-04-09 16:22             ` Oleg Nesterov
2008-04-09 18:40               ` David Woodhouse
2008-03-29  0:14 ` [PATCH 3/4] s390 renumber TIF_RESTORE_SIGMASK Roland McGrath
2008-03-31  7:53   ` Martin Schwidefsky
2008-03-29  0:14 ` [PATCH 4/4] ia64 " Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0803281746480.14670@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox