From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Date: Wed, 03 Sep 2008 21:22:36 +0000 Subject: Re: [PATCH] Correct printk %pF to work on all architectures Message-Id: List-Id: References: <1220473137.3254.29.camel@localhost.localdomain> In-Reply-To: <1220473137.3254.29.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Bottomley Cc: linux-arch@vger.kernel.org, Parisc List , linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org On Wed, 3 Sep 2008, James Bottomley wrote: > > Make dereference_function_descriptor() more accommodating by allowing > architecture overrides. Don't do it like this. We don't want some stupid useless weak function that is empty on all sane platforms. Just do .. declare or create an inline 'parisc_function_descriptor()' .. #define dereference_function_descriptor(p) parisc_function_descriptor(p) in some arch header file. And then use #ifndef dereference_function_descriptor #define dereference_function_descriptor(p) (p) #endif in the generic code, so that sane architectures don't need to do anything at all. Linus