From: Thomas Gleixner <tglx@linutronix.de>
To: Jiang Liu <liuj97@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Jes Sorensen <jes@sgi.com>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Yinghai Lu <yinghai@kernel.org>, Thomas Meyer <thomas@m3y3r.de>,
Jiang Liu <jiang.liu@huawei.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-altix@sgi.com, x86@kernel.org, chenkeping@huawei.com
Subject: Re: [PATCH] IRQ: normalize chip->irq_set_affinity return value on x86 and IA64
Date: Thu, 29 Mar 2012 09:58:49 +0000 [thread overview]
Message-ID: <alpine.LFD.2.02.1203291154010.2542@ionos> (raw)
In-Reply-To: <1331046112-19526-1-git-send-email-jiang.liu@huawei.com>
On Tue, 6 Mar 2012, Jiang Liu wrote:
> On x86 and IA64 platforms, interrupt controller chip's irq_set_affinity()
> method always copies affinity mask to irq_data->affinity field but still
> returns 0(IRQ_SET_MASK_OK). That return value causes the interrupt core
> logic unnecessarily copies the mask to irq_data->affinity field again.
> So return IRQ_SET_MASK_OK_NOCOPY instead of IRQ_SET_MASK_OK to get rid of
> the duplicated copy operation.
>
> This patch applies to v3.3-rc6 and has been tested on x86 platforms.
>
> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
> ---
> arch/ia64/kernel/iosapic.c | 4 +++-
> arch/ia64/kernel/msi_ia64.c | 4 ++--
> arch/ia64/sn/kernel/irq.c | 2 +-
> arch/ia64/sn/kernel/msi_sn.c | 2 +-
> arch/x86/kernel/apic/io_apic.c | 11 ++++++-----
> arch/x86/platform/uv/uv_irq.c | 2 +-
> kernel/irq/internals.h | 3 +++
> kernel/irq/manage.c | 39 ++++++++++++++++++++++-----------------
> kernel/irq/migration.c | 6 +-----
This does not work that way. The patch wants to be split in 3 parts
(core, x86, ia64). The patches are completely independent. Please
resend.
Thanks,
tglx
prev parent reply other threads:[~2012-03-29 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 15:01 [PATCH] IRQ: normalize chip->irq_set_affinity return value on x86 and IA64 Jiang Liu
2012-03-08 14:49 ` Dimitri Sivanich
2012-03-09 0:56 ` Jiang Liu
2012-03-29 9:58 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1203291154010.2542@ionos \
--to=tglx@linutronix.de \
--cc=chenkeping@huawei.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jes@sgi.com \
--cc=jiang.liu@huawei.com \
--cc=linux-altix@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox