From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Dufour Date: Tue, 15 Sep 2020 07:04:10 +0000 Subject: Re: [PATCH v2 1/3] mm: replace memmap_context by memplug_context Message-Id: List-Id: References: <20200914165042.96218-1-ldufour@linux.ibm.com> <20200914165042.96218-2-ldufour@linux.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: David Hildenbrand , akpm@linux-foundation.org, Oscar Salvador , mhocko@kernel.org, Greg Kroah-Hartman Cc: linux-mm@kvack.org, "Rafael J . Wysocki" , nathanl@linux.ibm.com, cheloha@linux.ibm.com, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Le 14/09/2020 à 19:10, David Hildenbrand a écrit : > On 14.09.20 18:50, Laurent Dufour wrote: >> The memmap_context is used to detect whether a memory operation is due to a >> hot-add operation or happening at boot time. >> >> Make it general to the hotplug operation and rename it at memplug_context. >> >> There is no functional change introduced by this patch >> >> Suggested-by: David Hildenbrand >> Signed-off-by: Laurent Dufour >> --- >> arch/ia64/mm/init.c | 6 +++--- >> include/linux/mm.h | 2 +- >> include/linux/mmzone.h | 11 ++++++++--- >> mm/memory_hotplug.c | 2 +- >> mm/page_alloc.c | 10 +++++----- >> 5 files changed, 18 insertions(+), 13 deletions(-) >> >> diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c >> index 0b3fb4c7af29..b5054b5e77c8 100644 >> --- a/arch/ia64/mm/init.c >> +++ b/arch/ia64/mm/init.c >> @@ -538,7 +538,7 @@ virtual_memmap_init(u64 start, u64 end, void *arg) >> if (map_start < map_end) >> memmap_init_zone((unsigned long)(map_end - map_start), >> args->nid, args->zone, page_to_pfn(map_start), >> - MEMMAP_EARLY, NULL); >> + MEMPLUG_EARLY, NULL); > > I am pretty sure that won't compile (MEMINIT_EARLY). > > (same at other places) Ouch I can't understand what I did at sending time, I did check compile on ia64 w and w/o memory hotplug. Sorry for the noise.