Re: [PATCH] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

kernel test robot
2021-03-01T09:52:45Z

[-- Attachment #1: Type: text/plain, Size: 6330 bytes --]

Hi Anshuman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on linus/master v5.12-rc1 next-20210301]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-Generalize-HUGETLB_PAGE_SIZE_VARIABLE/20210301-135205
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: ia64-randconfig-r003-20210301 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/fe78e3508e5221ac13aa288136e2a6506211be68
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Anshuman-Khandual/mm-Generalize-HUGETLB_PAGE_SIZE_VARIABLE/20210301-135205
git checkout fe78e3508e5221ac13aa288136e2a6506211be68
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from arch/ia64/include/asm/pgtable.h:154,
from include/linux/pgtable.h:6,
from include/linux/mm.h:33,
from mm/page_alloc.c:19:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
In file included from include/linux/kconfig.h:7,
from <command-line>:
mm/page_alloc.c: At top level:
>> ./include/generated/autoconf.h:269:36: error: expected identifier or '(' before numeric constant
269 | #define CONFIG_FORCE_MAX_ZONEORDER 11
| ^~
include/linux/mmzone.h:29:19: note: in expansion of macro 'CONFIG_FORCE_MAX_ZONEORDER'
29 | #define MAX_ORDER CONFIG_FORCE_MAX_ZONEORDER
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/pageblock-flags.h:48:27: note: in expansion of macro 'MAX_ORDER'
48 | #define pageblock_order (MAX_ORDER-1)
| ^~~~~~~~~
mm/page_alloc.c:250:14: note: in expansion of macro 'pageblock_order'
250 | unsigned int pageblock_order __read_mostly;
| ^~~~~~~~~~~~~~~
mm/page_alloc.c:2618:5: warning: no previous prototype for 'find_suitable_fallback' [-Wmissing-prototypes]
2618 | int find_suitable_fallback(struct free_area *area, unsigned int order,
| ^~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:3596:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
3596 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
| ^~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:6257:23: warning: no previous prototype for 'memmap_init' [-Wmissing-prototypes]
6257 | void __meminit __weak memmap_init(unsigned long size, int nid,
| ^~~~~~~~~~~
mm/page_alloc.c: In function 'set_pageblock_order':
>> mm/page_alloc.c:6798:6: error: 'HPAGE_SHIFT' undeclared (first use in this function); did you mean 'PAGE_SHIFT'?
6798 | if (HPAGE_SHIFT > PAGE_SHIFT)
| ^~~~~~~~~~~
| PAGE_SHIFT
mm/page_alloc.c:6798:6: note: each undeclared identifier is reported only once for each function it appears in
>> mm/page_alloc.c:6799:11: error: 'HUGETLB_PAGE_ORDER' undeclared (first use in this function)
6799 | order = HUGETLB_PAGE_ORDER;
| ^~~~~~~~~~~~~~~~~~
>> mm/page_alloc.c:6808:18: error: lvalue required as left operand of assignment
6808 | pageblock_order = order;
| ^

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for HUGETLB_PAGE_SIZE_VARIABLE
Depends on HUGETLB_PAGE
Selected by
- IA64

vim +/HUGETLB_PAGE_ORDER +6799 mm/page_alloc.c

ba72cb8cb0cdc0 Mel Gorman 2007-11-28 6788
d9c2340052278d Mel Gorman 2007-10-16 6789 /* Initialise the number of pages represented by NR_PAGEBLOCK_BITS */
03e85f9d5f1f8c Oscar Salvador 2018-08-21 6790 void __init set_pageblock_order(void)
d9c2340052278d Mel Gorman 2007-10-16 6791 {
955c1cd7401565 Andrew Morton 2012-05-29 6792 unsigned int order;
955c1cd7401565 Andrew Morton 2012-05-29 6793
d9c2340052278d Mel Gorman 2007-10-16 6794 /* Check that pageblock_nr_pages has not already been setup */
d9c2340052278d Mel Gorman 2007-10-16 6795 if (pageblock_order)
d9c2340052278d Mel Gorman 2007-10-16 6796 return;
d9c2340052278d Mel Gorman 2007-10-16 6797
955c1cd7401565 Andrew Morton 2012-05-29 @6798 if (HPAGE_SHIFT > PAGE_SHIFT)
955c1cd7401565 Andrew Morton 2012-05-29 @6799 order = HUGETLB_PAGE_ORDER;
955c1cd7401565 Andrew Morton 2012-05-29 6800 else
955c1cd7401565 Andrew Morton 2012-05-29 6801 order = MAX_ORDER - 1;
955c1cd7401565 Andrew Morton 2012-05-29 6802
d9c2340052278d Mel Gorman 2007-10-16 6803 /*
d9c2340052278d Mel Gorman 2007-10-16 6804 * Assume the largest contiguous order of interest is a huge page.
955c1cd7401565 Andrew Morton 2012-05-29 6805 * This value may be variable depending on boot parameters on IA64 and
955c1cd7401565 Andrew Morton 2012-05-29 6806 * powerpc.
d9c2340052278d Mel Gorman 2007-10-16 6807 */
d9c2340052278d Mel Gorman 2007-10-16 @6808 pageblock_order = order;
d9c2340052278d Mel Gorman 2007-10-16 6809 }
d9c2340052278d Mel Gorman 2007-10-16 6810 #else /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */
d9c2340052278d Mel Gorman 2007-10-16 6811

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28078 bytes --]