Re: autocompilation hosed?

[david mosberger <dmosberger@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

On 7/12/05, Tony Luck <tony.luck@gmail.com> wrote:
> > I'm also using gcc-4.0.1 by default now.  It basically seems to work
> > (apart from lots of additional annoying warning messages).  There is
> > one oddity: on my zx2000, it doesn't boot anymore without console=tty0
> > or console=ttyS0 arguments.  I'm not sure yet whether that's a
> > compiler-triggered problem or whether something changed in the kernel
> > that's causing this.
> 
> No ... I saw it too without gcc-4.  See http://tinyurl.com/clzbu where I
> identified the patch that seems to be the cause.

Patch below fixes the problem.  Moral of the story: don't add
"attributed(packed)" lightly!

  --david

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pcdp-fix.diff --]
[-- Type: text/x-patch; name="pcdp-fix.diff", Size: 606 bytes --]

[IA64] Make PCDP work again.

Mark's patch added "attribute((packed))" for pcdp_uart, without
accounting for the fact that the structure definition _relied_ on
implicit padding by 6 bytes.  Fix is to make the padding explicit.

Signed-off-by: David Mosberger-Tang <David.Mosberger@acm.org>

diff --git a/drivers/firmware/pcdp.h b/drivers/firmware/pcdp.h
--- a/drivers/firmware/pcdp.h
+++ b/drivers/firmware/pcdp.h
@@ -52,6 +52,8 @@ struct pcdp_uart {
 	u32				clock_rate;
 	u8				pci_prog_intfc;
 	u8				flags;
+	u16				conout_index;
+	u32				reserved;
 } __attribute__((packed));
 
 #define PCDP_IF_PCI	1