From: david mosberger <dmosberger@gmail.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Type qualifiers in __ia64_get_io_port_base
Date: Tue, 19 Jul 2005 02:06:55 +0000 [thread overview]
Message-ID: <ed5aea4305071819064a89f71b@mail.gmail.com> (raw)
In-Reply-To: <20050719012027.GA10518@cse.unsw.EDU.AU>
This one is wrong. It should use __attribute_const__ instead. If you
just drop the "const", it will result in worse code.
--david
On 7/18/05, Ian Wienand <ianw@gelato.unsw.edu.au> wrote:
> Fix
>
> include/asm/io.h:125: warning: type qualifiers ignored on function return type
>
> produced by gcc 4
>
> According to http://gcc.gnu.org/ml/gcc-patches/2000-10/msg00814.html
> the type qualifier is superfluous.
>
> --
>
> Signed-Off-By: Ian Wienand <ianw@gelato.unsw.edu.au>
>
> diff --git a/include/asm-ia64/io.h b/include/asm-ia64/io.h
> --- a/include/asm-ia64/io.h
> +++ b/include/asm-ia64/io.h
> @@ -120,7 +120,7 @@ static inline void ___ia64_mmiowb(void)
> ia64_mfa();
> }
>
> -static inline const unsigned long
> +static inline unsigned long
> __ia64_get_io_port_base (void)
> {
> extern unsigned long ia64_iobase;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2005-07-19 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-19 1:20 [PATCH] Type qualifiers in __ia64_get_io_port_base Ian Wienand
2005-07-19 2:06 ` david mosberger [this message]
2005-07-19 2:36 ` Ian Wienand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed5aea4305071819064a89f71b@mail.gmail.com \
--to=dmosberger@gmail.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox