From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Arnd Bergmann" Date: Thu, 04 May 2023 08:08:05 +0000 Subject: Re: [PATCH v4 0/6] fbdev: Move framebuffer I/O helpers to Message-Id: List-Id: References: <20230504074539.8181-1-tzimmermann@suse.de> In-Reply-To: <20230504074539.8181-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Zimmermann , Helge Deller , Geert Uytterhoeven , Javier Martinez Canillas , Daniel Vetter , Vineet Gupta , Huacai Chen , WANG Xuerui , "David S . Miller" , "James E . J . Bottomley" , Sam Ravnborg Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Linux-Arch , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org On Thu, May 4, 2023, at 09:45, Thomas Zimmermann wrote: > Fbdev provides helpers for framebuffer I/O, such as fb_readl(), > fb_writel() or fb_memcpy_to_fb(). The implementation of each helper > depends on the architecture, but they are all equivalent to regular > I/O functions of similar names. So use regular functions instead and > move all helpers into > > The first patch a simple whitespace cleanup. > > Until now, contained an include of . As this > will go away, patches 2 to 4 prepare include statements in the various > drivers. Source files that use regular I/O helpers, such as readl(), > now include . Source files that use framebuffer I/O > helpers, such as fb_readl(), now include . > > Patch 5 replaces the architecture-based if-else branching in > by helpers in . All helpers use Linux' > existing I/O functions. > > Patch 6 harmonizes naming among fbdev and existing I/O functions. > > The patchset has been built for a variety of platforms, such as x86-64, > arm, aarch64, ppc64, parisc, m64k, mips and sparc. The whole series looks good to me now, Reviewed-by: Arnd Bergmann