public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] Fix NULL-pointer dereference in ia64_machine_kexec()
Date: Thu, 25 Jan 2007 18:06:40 +0000	[thread overview]
Message-ID: <eparjg$nhq$1@sea.gmane.org> (raw)

This patch fixes a NULL-pointer dereference in ia64_machine_kexec().

The variable ia64_kimage is set in machine_kexec_prepare() which is called
from sys_kexec_load(). If kdump wasn't configured before, ia64_kimage is NULL.
machine_kdump_on_init() passes ia64_kimage() to machine_kexec() which assumes
a valid value.

The patch also adds a few sanity checks for the image to simplify debugging of
similar problems in future.

Signed-off-by: Bernhard Walle <bwalle@suse.de>
Acked-by: Raymund Will <rw@suse.de>

---
 arch/ia64/kernel/crash.c         |    4 ++++
 arch/ia64/kernel/machine_kexec.c |    2 ++
 2 files changed, 6 insertions(+)

Index: current-kernel/arch/ia64/kernel/crash.c
=================================--- current-kernel.orig/arch/ia64/kernel/crash.c
+++ current-kernel/arch/ia64/kernel/crash.c
@@ -116,6 +116,10 @@ machine_crash_shutdown(struct pt_regs *p
 static void
 machine_kdump_on_init(void)
 {
+       if (!ia64_kimage) {
+               printk(KERN_NOTICE "Kdump not configured\n");
+               return;
+       }
        local_irq_disable();
        kexec_disable_iosapic();
        machine_kexec(ia64_kimage);
Index: current-kernel/arch/ia64/kernel/machine_kexec.c
=================================--- current-kernel.orig/arch/ia64/kernel/machine_kexec.c
+++ current-kernel/arch/ia64/kernel/machine_kexec.c
@@ -93,6 +93,7 @@ static void ia64_machine_kexec(struct un
        unsigned long vector;
        int ii;
 
+       BUG_ON(!image);
        if (image->type = KEXEC_TYPE_CRASH) {
                crash_save_this_cpu();
                current->thread.ksp = (__u64)info->sw - 16;
@@ -131,6 +132,7 @@ static void ia64_machine_kexec(struct un
 
 void machine_kexec(struct kimage *image)
 {
+       BUG_ON(!image);
        unw_init_running(ia64_machine_kexec, image);
        for(;;);
 }


             reply	other threads:[~2007-01-25 18:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 18:06 Bernhard Walle [this message]
2007-01-27  6:28 ` [PATCH] Fix NULL-pointer dereference in ia64_machine_kexec() Jes Sorensen
2007-01-27 13:15 ` Bernhard Walle
2007-01-27 22:49 ` Jes Sorensen
2007-02-06 11:40   ` Bernhard Walle
2007-01-28 12:47 ` Bernhard Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='eparjg$nhq$1@sea.gmane.org' \
    --to=bwalle@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox