Re: [RFC V3] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()

Leonardo Bras
2019-06-10T15:27:02Z

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

On Mon, 2019-06-10 at 08:09 +0530, Anshuman Khandual wrote:
> > > + /*
> > > + * To be potentially processing a kprobe fault and to be allowed
> > > + * to call kprobe_running(), we have to be non-preemptible.
> > > + */
> > > + if (kprobes_built_in() && !preemptible() && !user_mode(regs)) {
> > > + if (kprobe_running() && kprobe_fault_handler(regs, trap))
> >
> > don't need an 'if A if B', can do 'if A && B'
>
> Which will make it a very lengthy condition check.

Well, is there any problem line-breaking the if condition?

if (A && B && C &&
D && E )

Also, if it's used only to decide the return value, maybe would be fine
to do somethink like that:

return (A && B && C &&
D && E );

Regards,

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]