From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: build broken for ia64 simserial.c
Date: Fri, 13 Jan 2006 22:46:38 +0000 [thread overview]
Message-ID: <je4q4721bl.fsf@sykes.suse.de> (raw)
In-Reply-To: <B8E391BBE9FE384DAA4C5C003888BE6F056BA512@scsmsx401.amr.corp.intel.com>
"Luck, Tony" <tony.luck@intel.com> writes:
> Alan,
>
> TTY layer buffering revamp broke ia64.
>
> CC arch/ia64/hp/sim/simserial.o
> arch/ia64/hp/sim/simserial.c: In function `receive_chars':
> arch/ia64/hp/sim/simserial.c:170: error: structure has no member named `flip'
> arch/ia64/hp/sim/simserial.c:172: error: structure has no member named `flip'
> arch/ia64/hp/sim/simserial.c:174: error: structure has no member named `flip'
> arch/ia64/hp/sim/simserial.c:176: error: structure has no member named `flip'
> arch/ia64/hp/sim/simserial.c:177: error: structure has no member named `flip'
> arch/ia64/hp/sim/simserial.c:178: error: structure has no member named `flip'
> make[1]: *** [arch/ia64/hp/sim/simserial.o] Error 1
>
> Any quick hints on the fix?
This should work (untested):
--- linux/arch/ia64/hp/sim/simserial.c.~1~ 2006-01-13 16:02:17.213612854 +0100
+++ linux/arch/ia64/hp/sim/simserial.c 2006-01-13 23:44:03.594619721 +0100
@@ -167,15 +167,9 @@ static void receive_chars(struct tty_st
}
}
seen_esc = 0;
- if (tty->flip.count >= TTY_FLIPBUF_SIZE) break;
- *tty->flip.char_buf_ptr = ch;
-
- *tty->flip.flag_buf_ptr = 0;
-
- tty->flip.flag_buf_ptr++;
- tty->flip.char_buf_ptr++;
- tty->flip.count++;
+ if (tty_insert_flip_char(tty, ch, TTY_NORMAL) = 0)
+ break;
}
tty_flip_buffer_push(tty);
}
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-01-13 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 19:58 build broken for ia64 simserial.c Luck, Tony
2006-01-13 22:46 ` Andreas Schwab [this message]
2006-01-13 22:57 ` Luck, Tony
2006-01-14 0:33 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je4q4721bl.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox