Re: [patch 5/5] ia64: update memory attribute aliasing documentation & test cases

[Andreas Schwab <schwab@suse.de>]

Bjorn Helgaas <bjorn.helgaas@hp.com> writes:

> @@ -138,14 +128,20 @@
>  
>      ioremap()
>  
> -	This returns a kernel identity mapping for use inside the
> -	kernel.
> +	This returns a mapping for use inside the kernel.
>  
>  	If the region is in kern_memmap, we should use the attribute
> -	specified there.  Otherwise, if the EFI memory map reports that
> -	the entire granule supports WB, we should use that (granules
> -	that are partially reserved or occupied by firmware do not appear
> -	in kern_memmap).  Otherwise, we should use a UC mapping.
> +	specified there.
> +
> +	If the EFI memory map reports that the entire granule supports
> +	WB, we should use that (granules that are partially reserved
> +	or occupied by firmware do not appear in kern_memmap).
> +
> +	If the granule contains non-WB memory, but we can cover the
> +	region safely with kernel page table mappings, we can use
> +	ioremap_page_range() as most other architectures do.
> +
> +	Failing all of the above, we have to all back to a UC mapping.

s/all back/fall back/

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."