From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Fix asm constraint in put_user
Date: Mon, 21 Nov 2005 15:12:19 +0000 [thread overview]
Message-ID: <je7jb2nigc.fsf@sykes.suse.de> (raw)
The st insn on the ia64 does not allow the post-increment to come from a
register (only ld does). Thus the "m" constraint is not suitable for the
asm statement in __put_user_size.
Signed-off-by: Andreas Schwab <schwab@suse.de>
--- linux-2.6.14/include/asm-ia64/uaccess.h.~1~ 2005-10-28 02:02:08.000000000 +0200
+++ linux-2.6.14/include/asm-ia64/uaccess.h 2005-11-20 18:15:46.559296784 +0100
@@ -154,10 +154,10 @@ do { \
# define __put_user_size(val, addr, n, err) \
do { \
register long __pu_r8 asm ("r8") = 0; \
- asm volatile ("\n[1:]\tst"#n" %1=%r2%P1\t// %0 gets overwritten by exception handler\n" \
+ asm volatile ("\n[1:]\tst"#n" [%1]=%r2\t// %0 gets overwritten by exception handler\n" \
"\t.xdata4 \"__ex_table\", 1b-., 1f-.\n" \
"[1:]" \
- : "=r"(__pu_r8) : "m"(__m(addr)), "rO"(val), "0"(__pu_r8)); \
+ : "=r"(__pu_r8) : "r"(addr), "rO"(val), "0"(__pu_r8)); \
(err) = __pu_r8; \
} while (0)
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2005-11-21 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 15:12 Andreas Schwab [this message]
2005-11-21 16:08 ` Fix asm constraint in put_user David Mosberger-Tang
2005-11-21 16:48 ` Andreas Schwab
2005-11-21 19:03 ` James E Wilson
2005-11-21 20:32 ` Andreas Schwab
2005-11-21 21:26 ` Andreas Schwab
2005-11-21 22:11 ` Luck, Tony
2005-11-21 22:38 ` David Mosberger-Tang
2005-11-23 6:02 ` James E Wilson
2005-11-23 22:08 ` James E Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je7jb2nigc.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox