From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] cleanup XPC disengage related messages (v2)
Date: Thu, 05 Jan 2006 22:04:41 +0000 [thread overview]
Message-ID: <jer77mnxfq.fsf@sykes.suse.de> (raw)
In-Reply-To: <43AC2281.mailxDCB118CPI@aqua.americas.sgi.com>
Dean Nelson <dcn@sgi.com> writes:
> + if (xpc_partition_engaged(-1UL)) {
> + if (jiffies >= printmsg_time) {
This should use time_after().
> + if (!(volatile int) xpc_disengage_request_timedout) {
This cast is useless. Qualifiers are ignored on non-lvalues.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-01-05 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-23 16:14 [PATCH] cleanup XPC disengage related messages Dean Nelson
2006-01-05 18:43 ` [PATCH] cleanup XPC disengage related messages (v2) Dean Nelson
2006-01-05 22:04 ` Andreas Schwab [this message]
2006-01-06 15:48 ` [PATCH] cleanup XPC disengage related messages (v3) Dean Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jer77mnxfq.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox