From: Francis Galiegue <fg@mandrakesoft.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] [PATCH?] Compile fixes for UP ia64 - IRQ stuff (RESEND)
Date: Thu, 01 Mar 2001 18:19:35 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590693005234@msgid-missing> (raw)
[-- Attachment #1: Type: TEXT/PLAIN, Size: 809 bytes --]
[same as previous mail... Sent 6 hrs ago but did not arrive]
OK, I've found what was wrong... Attached patch is over 2.4.2 plus 010228
patch, and it fixes the following:
- include/asm-ia64/hardirq.h: invalid local_irq_count() usage in
local_enter_irq()
- arch/ia64/kernel/irq_ia64.c: IPI was registered on UP also, but I don't think
it's used at all (or is it?), and what's more ipi_irqaction definition is
surrounded by #ifdef CONFIG_SMP .. #endif. So I also #ifdef'ed the IPI
registering out.
WDYT?
--
Francis Galiegue, fg@mandrakesoft.com - Normand et fier de l'être
"Programming is a race between programmers, who try and make more and more
idiot-proof software, and universe, which produces more and more remarkable
idiots. Until now, universe leads the race" -- R. Cook
[-- Attachment #2: Type: TEXT/PLAIN, Size: 1152 bytes --]
diff -urN linux-old/arch/ia64/kernel/irq_ia64.c linux/arch/ia64/kernel/irq_ia64.c
--- linux-old/arch/ia64/kernel/irq_ia64.c Thu Mar 1 06:54:17 2001
+++ linux/arch/ia64/kernel/irq_ia64.c Thu Mar 1 07:10:06 2001
@@ -155,7 +155,9 @@
init_IRQ (void)
{
register_percpu_irq(IA64_SPURIOUS_INT_VECTOR, NULL);
+#ifdef CONFIG_SMP
register_percpu_irq(IA64_IPI_VECTOR, &ipi_irqaction);
+#endif
platform_irq_init();
}
Binary files linux-old/arch/ia64/tools/print_offsets and linux/arch/ia64/tools/print_offsets differ
diff -urN linux-old/include/asm-ia64/hardirq.h linux/include/asm-ia64/hardirq.h
--- linux-old/include/asm-ia64/hardirq.h Thu Mar 1 06:54:19 2001
+++ linux/include/asm-ia64/hardirq.h Thu Mar 1 07:06:42 2001
@@ -41,8 +41,8 @@
# define local_hardirq_trylock() (local_irq_count() == 0)
# define local_hardirq_endlock() do { } while (0)
-# define local_irq_enter(irq) (local_irq_count(cpu)++)
-# define local_irq_exit(irq) (local_irq_count(cpu)--)
+# define local_irq_enter(irq) (local_irq_count()++)
+# define local_irq_exit(irq) (local_irq_count()--)
# define synchronize_irq() barrier()
#else
reply other threads:[~2001-03-01 18:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590693005234@msgid-missing \
--to=fg@mandrakesoft.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox