public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] Announcing efibootmgr-0.2.0
Date: Wed, 16 May 2001 10:33:39 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590693005588@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590693005585@msgid-missing>

Matt_Domsch@Dell.com writes:

|> Announcing efibootmgr-0.2.0, a Linux user-space application which interacts
|> with the EFI Boot Manager.  It may be downloaded from
|> http://domsch.com/linux/ia64/efibootmgr-0.2.0.tar.gz.

Here is another patch that fixes a crash.

--- efibootmgr-0.2.0/src/lib/efi.c.~1~	Wed May 16 12:16:03 2001
+++ efibootmgr-0.2.0/src/lib/efi.c	Wed May 16 12:31:02 2001
@@ -88,7 +88,6 @@
 efi_status_t
 write_variable(efi_variable_t *var)
 {
-	char *newname;
 	int fd;
 	size_t writesize;
 	char buffer[PATH_MAX];
@@ -99,7 +98,6 @@
 	if (fd == -1) {
 		sprintf(buffer, "write_variable():open(%s)", name);
 		perror(buffer);
-		free(newname);
 		return EFI_INVALID_PARAMETER;
 	}
 	writesize = write(fd, var, sizeof(*var));
@@ -108,7 +106,6 @@
 		sprintf(buffer, "write_variable():write(%s)", name);
 		perror(buffer);
 		dump_raw_data(var, sizeof(*var));
-		free(newname);
 #endif
 		close(fd);
 		return EFI_INVALID_PARAMETER;

Andreas.

-- 
Andreas Schwab                                  "And now for something
SuSE Labs                                        completely different."
Andreas.Schwab@suse.de
SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5


      parent reply	other threads:[~2001-05-16 10:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-16  0:04 [Linux-ia64] Announcing efibootmgr-0.2.0 Matt_Domsch
2001-05-16 10:28 ` Andreas Schwab
2001-05-16 10:33 ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590693005588@msgid-missing \
    --to=schwab@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox