public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Bill Nottingham <notting@redhat.com>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] [PATCH] fix elilo invocations from the boot manager
Date: Tue, 05 Jun 2001 18:24:11 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590693005695@msgid-missing> (raw)

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

In some odd cases, when the boot manager invokes elilo, argc is 0,
while Optind is initialized to 1. If we continue with prompting
disabled, strange things can happen. (usually, attempts to boot
a non-existant kernel.)

Bill

[-- Attachment #2: elilo-2.5-prompt.patch --]
[-- Type: text/plain, Size: 394 bytes --]

diff -ru gnu-efi-2.5/elilo/elilo.c ook/elilo/elilo.c
--- elilo/elilo.c	Mon May 21 17:58:56 2001
+++ elilo/elilo.c	Tue Jun  5 14:02:04 2001
@@ -373,7 +381,7 @@
 	 * if user specified a kernel name or label, then ignore
 	 * forced interactive mode
 	 */
-	if (argv[Optind]) elilo_opt.prompt = 0;
+	if (argv[Optind] && Optind <= argc) elilo_opt.prompt = 0;
 
 	/*
 	 * which chooser we will use 

             reply	other threads:[~2001-06-05 18:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-05 18:24 Bill Nottingham [this message]
2001-06-07 16:00 ` [Linux-ia64] [PATCH] fix elilo invocations from the boot manager Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590693005695@msgid-missing \
    --to=notting@redhat.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox