From: Richard Hirst <rhirst@linuxcare.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] 010626 kernel, copy_from_user() broken?
Date: Fri, 20 Jul 2001 17:33:34 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590693005856@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590693005846@msgid-missing>
On Thu, Jul 19, 2001 at 12:25:35PM -0700, David Mosberger wrote:
> >>>>> On Thu, 12 Jul 2001 12:16:58 +0100, Richard Hirst <rhirst@linuxcare.com> said:
>
> Rich> Hi, Summary: I had to change PIPE_DEPTH in
> Rich> arch/ia64/lib/copy_user.S from 21 to 4 to make
> Rich> copy_from_user() work with non-aligned user addresses on my B3
> Rich> cpu. PIPE_DEPTH was 4 in the 010530 kernel.
>
> Thanks for reporting this (and for tracking it down!). It turns out
> that the author of the copy_user() recovery code either knowingly or
> accidentally assumed that PIPE_DEPTH=4, which is of course not good
> as it defeats the whole purpose of making the sw-pipelined loop
> tunable. The patch below should fix this. Can you try it instead and
> let me know how it goes?
Works fine, thanks.
Richard
prev parent reply other threads:[~2001-07-20 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-12 11:16 [Linux-ia64] 010626 kernel, copy_from_user() broken? Richard Hirst
2001-07-19 19:25 ` David Mosberger
2001-07-19 22:14 ` Nakajima, Jun
2001-07-20 17:33 ` Richard Hirst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590693005856@msgid-missing \
--to=rhirst@linuxcare.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox