From: Keith Owens <kaos@ocs.com.au>
To: linux-ia64@vger.kernel.org
Subject: [Linux-ia64] console_loglevel is broken on ia64
Date: Wed, 17 Oct 2001 13:25:02 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590698805357@msgid-missing> (raw)
kernel/printk.c has this abomination.
/* Keep together for sysctl support */
int console_loglevel = DEFAULT_CONSOLE_LOGLEVEL;
int default_message_loglevel = DEFAULT_MESSAGE_LOGLEVEL;
int minimum_console_loglevel = MINIMUM_CONSOLE_LOGLEVEL;
int default_console_loglevel = DEFAULT_CONSOLE_LOGLEVEL;
sysctl assumes that the 4 variables occupy contiguous storage. They
don't on ia64, console_loglevel is separate from the other variables.
echo 6 4 1 7 > /proc/sys/kernel/printk
on ia64 overwrites console_loglevel and the next 3 integers, whatever
they happen to be. On 2.4.12 it corrupts console_sem, other ia64
kernels will corrupt different data.
Does anybody fancy a small project to clean up these variables? They
need to become an integer array (say console_printk) containing 4
elements, which is what sysctl assumes. All references to these fields
have to be changed to refer to the corresponding array element. That
should be as simple as
#define console_loglevel (console_printk[0])
in kernel.h, as long as no other files declare console_loglevel or the
other variables. Alas at least two other files declare console_loglevel,
they need to be fixed to use the common declaration. I have not
checked the other console_xxx variables for extra declarations.
arch/parisc/kernel/traps.c: extern int console_loglevel;
arch/i386/mm/fault.c:extern int console_loglevel;
reply other threads:[~2001-10-17 13:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590698805357@msgid-missing \
--to=kaos@ocs.com.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox