From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?G=E9rard_Roudier?= Date: Mon, 03 Dec 2001 18:23:38 +0000 Subject: Re: [Linux-ia64] 2.4.16-ia64-011128 is missing dma64_addr_t Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-ia64@vger.kernel.org On Mon, 3 Dec 2001, David Mosberger wrote: > This error appears to be due to a bug in the sym53c8xx_2 driver. Note > that dma64_addr_t should be used only for the pci_dac_* interface, > which I do not want to support on ia64 unless and until we absolutely > have to (technically, there is no need for pci_dac_* on ia64 or x86). > > If you need a 64-bit integer type, just use u64 instead. Hmmm.... The hardware hasn't knowledge of abstractions used in the kernel. The dma_addr_t thing that can be 32 or 64 bits at kernel developer convenience does not help significantly, in my opinion, when actually talking with real hardware is in concern. Speaking for me, all bus-related bloaty things that exist on various kernels I have ported the driver (for now Linux + 2 BSDs) did not help me a single pico-second. They look to me rather confusing stuff and results of fards of brain. At the very most, they seem to be complex band-aids to support marginal hardwares designed by stupid hardware ingenieers that wanted to reinvent the wheel but didn't succeed. Sorry for having missed this dma detail in sym53c8xx_2 driver, but I cannot accept your 'bug' statement. Extremally bogus are proprietary hardwares that require much complexity in driver development, hence injecting useless bloat and bugs and, may-be, just sometimes discouraging people to develop drivers as a sad result. G=E9rard. > --david > > ---------------------------------------------- > From: Keith Owens > Sender: linux-ia64-admin@linuxia64.org > To: linux-ia64@linuxia64.org > Subject: [Linux-ia64] 2.4.16-ia64-011128 is missing dma64_addr_t > Date: Sun, 02 Dec 2001 14:56:44 +1100 > > 2.4.16-ia64-011128 has no definition for dma64_addr_t. > drivers/scsi/sym53c8xx_2/sym_glue.c:306: parse error before `bus_addr_t' > > Index: 16.6/include/asm-ia64/types.h > --- 16.6/include/asm-ia64/types.h Fri, 05 Jan 2001 13:42:29 +1100 kaos (l= inux-2.4/s/24_types.h 1.1 644) > +++ 16.6(w)/include/asm-ia64/types.h Sun, 02 Dec 2001 14:46:52 +1100 kaos= (linux-2.4/s/24_types.h 1.1 644) > @@ -63,6 +63,7 @@ typedef __u64 u64; > /* DMA addresses are 64-bits wide, in general. */ > > typedef u64 dma_addr_t; > +typedef u64 dma64_addr_t; > > # endif /* __KERNEL__ */ > #endif /* !__ASSEMBLY__ */ > > > _______________________________________________ > Linux-IA64 mailing list > Linux-IA64@linuxia64.org > http://lists.linuxia64.org/lists/listinfo/linux-ia64 > >